Re: Full 1.1 Test Suite Status Updated

Hi Patrick.

Patrick Dengler:
> pservers-grad-23-f - Changed stop-color to inherit based upon
> feedback.

Thanks for implementing my suggested change.  As well that, there was
this change:

-  <g id="test-body-content" font-family="SVGFreeSansASCII,sans-serif" font-size="18">
+  <g id="test-body-content" font-size="18">

Was this deliberate?  That line is part of the test template.  This test
doesn’t need SVG fonts, and the pass criteria don’t need SVG fonts to be
implemented for the test to pass.  The use of SVGFreeSansASCII there is
solely to help those who are doing pixel testing for the tests across
platforms/systems where sans-serif is going to map to a different font,
as I understand it.  I’d be totally fine with changing the template to
have other font format fallback(s) there, if everyone else agreed.

(The test template is kind of heavyweight if we want to move towards
reftests – and in fact with reftests there’s no particular value in
using SVGFreeSansASCII here rather than sans-serif and whatever that
maps to.  But that is probably a separate discussion.)

I didn’t mention this in my first round of review comments (and I
certainly don’t mind fixing these up myself), but the MS submitted tests
seem to have their test descriptions commented out, which they shouldn’t
be.

> struct-cond-overview-05-f - Added sub-test for a check that a <use>   
> element referencing a child element (without a conditional attribute) 
> of some element that does have a failing conditional attribute is     
> rendered.                                                             
>
> struct-dom-16-f - Added sub-test for createSVGTransform() to also
> check that the .matrix and .angle properties are appropriately
> initialized
>
> text-fonts-05-f - Fixed link to Fonts

Not sure what “Fixed link to Fonts” means, but the line-height changes
are good. :)  Did you have any response to this comment I had?

  | Another thing that should be tested is that baseline-adjust
  | percentage values are relative to the font size of the element,
  | rather than whatever value is specified for line-height.  (That’s
  | the only property whose values are relative to line-height, I
  | believe.)                                    

> types-dom-svgfittoviewbox-01-f - Added sub-test for the meetOrSlice
> property of the SVGPreserveAspectRatio object.

The remainder of the changes for my comments look fine, thanks!

-- 
Cameron McCormack ≝ http://mcc.id.au/

Received on Friday, 19 November 2010 18:20:08 UTC