Re: Update on ACTION-2771 - Rewrite styling-pres-02-f.svg to not use getPresentationAttribute

On Tue, 11 May 2010 14:25:43 +0200, Chris Lilley <chris@w3.org> wrote:

> On Tuesday, May 11, 2010, 1:04:37 PM, Erik wrote:
>
> ED> Hi,
>
> ED> I've committed a modified version of the styling-pres-02-f.svg[1]
> ED> testcase. I'd like someone to review it again, since it was changed  
> quite
> ED> a bit (see changelog[2]).
>
> This might be a bit pathological, but wouldn't
>
> v.toUpperCase() == longhex.toUpperCase();
>
> be a safer thing to test? #3c5FeD is a legal value ...

Yes, feel free to make that change.

> In general this looks good to me. Since I am already the reviewer and  
> tha estaus is already reviewed, nothing to do ...
>
>
> ED> Preliminary testresults:
> ED> Batik1.7: pass
> ED> Opera10.53: pass
> ED> Safari4.0.3: pass
> ED> Firefox3.5.8: fail
> ED> Iron4.0.275.2 (35171): fail (crash)
>
> Iron?

Well, it's a metal, so it must be close to chromium I suppose ;)

Pending the minor change above, can we approve the test? FWIW I think it's  
ok.

Cheers
/Erik

-- 
Erik Dahlstrom, Core Technology Developer, Opera Software
Co-Chair, W3C SVG Working Group
Personal blog: http://my.opera.com/macdev_ed

Received on Tuesday, 11 May 2010 13:17:01 UTC