Re: Update on ACTION-2771 - Rewrite styling-pres-02-f.svg to not use getPresentationAttribute

On Tuesday, May 11, 2010, 1:04:37 PM, Erik wrote:

ED> Hi,

ED> I've committed a modified version of the styling-pres-02-f.svg[1]  
ED> testcase. I'd like someone to review it again, since it was changed quite
ED> a bit (see changelog[2]).

This might be a bit pathological, but wouldn't 

v.toUpperCase() == longhex.toUpperCase();

be a safer thing to test? #3c5FeD is a legal value ...

In general this looks good to me. Since I am already the reviewer and tha estaus is already reviewed, nothing to do ...


ED> Preliminary testresults:
ED> Batik1.7: pass
ED> Opera10.53: pass
ED> Safari4.0.3: pass
ED> Firefox3.5.8: fail
ED> Iron4.0.275.2 (35171): fail (crash)

Iron?


ED> Cheers
ED> /Erik

ED> [1]
ED> http://dev.w3.org/SVG/profiles/1.1F2/test/svg/styling-pres-02-f.svg
ED> [2]  
ED> http://dev.w3.org/cvsweb/SVG/profiles/1.1F2/test/svg/styling-pres-02-f.svg.diff?r1=1.5&r2=1.7&f=h





-- 
 Chris Lilley                    mailto:chris@w3.org
 Technical Director, Interaction Domain
 W3C Graphics Activity Lead
 Co-Chair, W3C Hypertext CG

Received on Tuesday, 11 May 2010 12:25:46 UTC