W3C home > Mailing lists > Public > public-svg-wg@w3.org > April to June 2010

Review of pservers-grad-22-b.svg

From: Erik Dahlstrom <ed@opera.com>
Date: Tue, 20 Apr 2010 11:25:07 +0200
To: "public-svg-wg@w3.org" <public-svg-wg@w3.org>
Cc: "Anthony Grasso" <anthony.grasso@cisra.canon.com.au>
Message-ID: <op.vbge32p4geuyw5@localhost>
Hi,

here's my review of the pservers-grad-22-b.svg test.

 From test description:
[[ Tests that object transforms affect the rendering of a gradient that is  
referenced by the object. ]]

How about: "Tests that transforms affect the rendering of a gradient."?

 From pass criteria:
[[ This test is passed if the gradient referenced by the top object is  
transformed by the transform that transforms the object. ]]

Not sure that sentence is needed (and it's a bit confusing with all the  
transforms :), I suggest simply saying that the two gradients should look  
identical for the test to pass.

I would like to see a subtest using gradientTransform in combination with  
the existing subtests too.

Cheers
/Erik

-- 
Erik Dahlstrom, Core Technology Developer, Opera Software
Co-Chair, W3C SVG Working Group
Personal blog: http://my.opera.com/macdev_ed
Received on Tuesday, 20 April 2010 09:25:46 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 17:29:43 UTC