Re: Testsuite: uDom tests - setAttributeNS vs. setTrait

> AN> The tests use .setAttributeNS() to set attributes. I wonder if there is
> AN> a prefered way to set attributes - should we use setTrait() or 
> AN> setAttributeNS ?
> 
> I wasn't clear on that myself. For attributes typed as a string, traits offer no additional value. For structured types lik ecolors, it seems better to use traits. But we need to discuss this more, I think.

ok - this sounds reasonable. Just tell me if you discussed anything 
different.

> 
> AN> Another question: when should the draft banner be removed or commented
> AN> out? After reviewing, before creating the reference image or after the
> AN> test is approved?
> 
> After approval.

ok

Andreas

-- 

--
Andreas Neumann
Böschacherstrasse 6
CH-8624 Grüt (Gossau ZH)
Switzerland
Phone: ++41-44-2736668
Email: a.neumann@carto.net

Web: http://www.carto.net/neumann/
SVG Examples: http://www.carto.net/papers/svg/samples/
SVG.Open: http://www.svgopen.org/

Received on Tuesday, 20 May 2008 09:02:16 UTC