- From: Eric Prud'hommeaux via GitHub <sysbot+gh@w3.org>
- Date: Wed, 29 Jun 2022 13:57:21 +0000
- To: public-shex-dev@w3.org
> Are there new tests that show the advantage of this indirection rather than just the extra overhead of indirection? I don't think the tests show it off. The ShExJ.jsg is [a ton simpler](https://github.com/shexSpec/shexTest/pull/51/files#diff-2ce28ebfc234134f39bac3ed989e57c05fa3d92d383182e875860ffe0c7f1b4b). I think the strongest case comes from diving into an implementation and seeing the number of potential bugs that disappear. There are lots of places where I wasn't conditionally traversing the ShapeDecls's `.shexExpr` ([e.g.](https://github.com/shexjs/shex.js/pull/103/files#diff-7ed4dcefe40c6a75f2223de310ce8c9a311e5a08823ebee92e71b480f266d011L532)) because I hadn't happened to hit those lines with a schema that needed a ShapeDecl (i.e. had `.abstract` set to true). -- GitHub Notification of comment by ericprud Please view or discuss this issue at https://github.com/shexSpec/shexTest/pull/51#issuecomment-1170015201 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Wednesday, 29 June 2022 13:57:23 UTC