Re: [primer] Minor comments on the primer

Hi Lars,

We have accepted most all of your changes (thank you!) [1,2]

We thought of two more good examples to illustrate different types of
Value Set: 1) URI (ex:unassigned), 2) literal ("unassigned") 3) integer
(0).

We have two remaining issues [3,4].  For example, you wondered why the
passing and failing data were not presented in sequence, as they usually
are, and Eric feels that simply adding a "try it" button to the data in
4.1 could usefully present a block of data that both passes and fails.

We both have other deadlines to meet and simply ran out of time for now
but will return to complete these.

Tom

[1] https://github.com/shexSpec/primer/compare/41122f4...ecd904b?diff=split&name=ecd904b
[2] https://github.com/shexSpec/primer/pull/11/files
[3] https://github.com/shexSpec/primer/pull/11#discussion_r154493324
[4] https://github.com/shexSpec/primer/pull/11#discussion_r154493484

-- 
Tom Baker <tom@tombaker.org>


-- 
GitHub Notification of comment by tombaker
Please view or discuss this issue at https://github.com/shexSpec/primer/issues/10#issuecomment-348694557 using your GitHub account

Received on Saturday, 2 December 2017 14:10:49 UTC