Re: patches to DM tests from Eric Prud'hommeaux on 2012-03-19 (public-rdb2rdf-wg@w3.org from March 2012)

From: Eric Prud'hommeaux <eric@w3.org>
Date: Mon, 19 Mar 2012 13:09:23 -0400
To: public-rdb2rdf-wg@w3.org
Message-ID: <20120319170922.GJ17404@w3.org>
* Eric Prud'hommeaux <eric@w3.org> [2012-03-13 11:44-0400]
> With this patches, I can pass all the DM tests. Many of these changes
> are name changes (e.g. matching case in the create.sql). Also, to
> enable graph equivalence, I changed the reference graphs to canonical
> lexical forms (e.g. for xsd:double). These directMapping.nt files
> parse as Turtle.

Here's a new set of patches to the ttl files. I've annotated this with
justifications; you can look for them (or strip them out for
application with patch) by searching for the regex ^#.

diff -r 5a6368032f1e D003-1table3columns1row/directGraph.ttl
--- a/D003-1table3columns1row/directGraph.ttl	Fri Mar 16 01:33:45 2012 +0100
+++ b/D003-1table3columns1row/directGraph.ttl	Mon Mar 19 12:05:32 2012 -0400
@@ -1,4 +1,4 @@
 _:a <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <Student> .
-_:a <Student#ID> "10"^<http://www.w3.org/2001/XMLSchema#integer> .
+_:a <Student#ID> "10"^^<http://www.w3.org/2001/XMLSchema#integer> .
# "^^" indicates a datatype.
 _:a <Student#FirstName> "Venus" .
 _:a <Student#LastName> "Williams" .
diff -r 5a6368032f1e D014-3tables1primarykey1foreignkey/directGraph.ttl
--- a/D014-3tables1primarykey1foreignkey/directGraph.ttl	Fri Mar 16 01:33:45 2012 +0100
+++ b/D014-3tables1primarykey1foreignkey/directGraph.ttl	Mon Mar 19 12:05:32 2012 -0400
@@ -1,7 +1,7 @@
 <EMP/empno-7369> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <EMP> .
 <EMP/empno-7369> <EMP#empno> "7369"^^<http://www.w3.org/2001/XMLSchema#integer>  .
 <EMP/empno-7369> <EMP#deptno> "10"^^<http://www.w3.org/2001/XMLSchema#integer>  .
-<EMP/empno-7369> <EMP#ref-deptno> <DEPT/deptno-10>  .
+<EMP/empno-7369> <EMP#ref-deptno> _:c  .
# DEPT has no primary key.
 <EMP/empno-7369> <EMP#ename> "SMITH" .
 <EMP/empno-7369> <EMP#job> "CLERK" .
 <EMP/empno-7369> <EMP#etype> "PART_TIME" .
diff -r 5a6368032f1e D016-1table1primarykey10columns3rowsSQLdatatypes/create.sql
--- a/D016-1table1primarykey10columns3rowsSQLdatatypes/create.sql	Fri Mar 16 01:33:45 2012 +0100
+++ b/D016-1table1primarykey10columns3rowsSQLdatatypes/create.sql	Mon Mar 19 12:05:32 2012 -0400
@@ -8,21 +8,21 @@
 "BirthDate" DATE,
 "EntranceDate" TIMESTAMP,
 "PaidInAdvance" BOOLEAN,
-"Photo" VARBINARY(200),
+"Photo" BINARY VARYING(200),
# The Mimer SQL-2003 validator says there's no VARBINARY (but I haven't dug through the 2009 grammar and Mimer doesn't validate 2009).
 PRIMARY KEY ("ID")
 );
 
 INSERT INTO "Patient" ("ID", "FirstName","LastName","Sex","Weight","Height","BirthDate","EntranceDate","PaidInAdvance","Photo") 
 VALUES (10,'Monica','Geller','female',80.25,1.65,'1981-10-10','2009-10-10 12:12:22',FALSE, CAST(
 'iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAYAAACNbyblAAAAHElEQVQI12P4\ux2F\ux2F8\ux2Fw38GIAXDIBKE0DHxgljNBAAO9TXL0Y4OHwAAAABJRU5ErkJggg\ux3D\ux3D'
-AS VARBINARY(200)));
+AS BINARY VARYING(200)));
 
 INSERT INTO "Patient" ("ID", "FirstName","LastName","Sex","Weight","Height","BirthDate","EntranceDate","PaidInAdvance","Photo") 
 VALUES (11,'Rachel','Green','female',70.22,1.70,'1982-11-12','2008-11-12 09:45:44',TRUE,CAST(
 'iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAYAAACNbyblAAAAHElEQVQI12P5\ux2F\ux2F8\ux2Fw38GIAXDIBKE0DHxgljNBAAO9TXL0Y4OHwAAAABJRU5ErkJggg\ux3D\ux3D'
-AS VARBINARY(200)));
+AS BINARY VARYING(200)));
 
 INSERT INTO "Patient" ("ID", "FirstName","LastName","Sex","Weight","Height","BirthDate","EntranceDate","PaidInAdvance","Photo") 
 VALUES (12,'Chandler','Bing','male',90.31,1.76,'1978-04-06','2007-03-12 02:13:14',TRUE,CAST(
 'iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAYAAACNbyblAAAAHElEQVQI12P5\ux2F\ux2F6\ux2Fw38GIAXDIBKE0DHxgljNBAAO9TXL0Y4OHwAAAABJRU5ErkJggg\ux3D\ux3D' 
-AS VARBINARY(200)));
\ No newline at end of file
+AS BINARY VARYING(200)));
\ No newline at end of file
diff -r 5a6368032f1e D016-1table1primarykey10columns3rowsSQLdatatypes/directGraph.ttl
--- a/D016-1table1primarykey10columns3rowsSQLdatatypes/directGraph.ttl	Fri Mar 16 01:33:45 2012 +0100
+++ b/D016-1table1primarykey10columns3rowsSQLdatatypes/directGraph.ttl	Mon Mar 19 12:05:32 2012 -0400
@@ -8,7 +8,7 @@
 <Patient/ID-10> <Patient#BirthDate> "1981-10-10"^^<http://www.w3.org/2001/XMLSchema#date> .
 <Patient/ID-10> <Patient#EntranceDate> "2009-10-10T12:12:22"^^<http://www.w3.org/2001/XMLSchema#dateTime> .
 <Patient/ID-10> <Patient#PaidInAdvance> "false"^^<http://www.w3.org/2001/XMLSchema#boolean> .
-<Patient/ID-10> <Patient#Photo> "iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAYAAACNbyblAAAAHElEQVQI12P4//8/w38GIAXDIBKE0DHxgljNBAAO9TXL0Y4OHwAAAABJRU5ErkJggg=="^^<http://www.w3.org/2001/XMLSchema#base64Binary> .
+<Patient/ID-10> <Patient#Photo> "aVZCT1J3MEtHZ29BQUFBTlNVaEVVZ0FBQUFVQUFBQUZDQVlBQUFDTmJ5YmxBQUFBSEVsRVFWUUkxMlA0Ly84L3czOEdJQVhESUJLRTBESHhnbGpOQkFBTzlUWEwwWTRPSHdBQUFBQkpSVTVFcmtKZ2dnPT0="^^<http://www.w3.org/2001/XMLSchema#base64Binary> .
# The beginning of the Photo value looks like a base-64-encoded PNG, but that doesn't permit \uxXX sequences. In order to pass the tests, I base64-encoded the values inserted in SQL.
 <Patient/ID-11> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <Patient> .
 <Patient/ID-11> <Patient#ID> "11"^^<http://www.w3.org/2001/XMLSchema#integer> .
 <Patient/ID-11> <Patient#FirstName> "Rachel" .
@@ -19,7 +19,7 @@
 <Patient/ID-11> <Patient#BirthDate> "1982-11-12"^^<http://www.w3.org/2001/XMLSchema#date> .
 <Patient/ID-11> <Patient#EntranceDate> "2008-11-12T09:45:44"^^<http://www.w3.org/2001/XMLSchema#dateTime> .
 <Patient/ID-11> <Patient#PaidInAdvance> "true"^^<http://www.w3.org/2001/XMLSchema#boolean> .
-<Patient/ID-11> <Patient#Photo> "iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAYAAACNbyblAAAAHElEQVQI12P5//8/w38GIAXDIBKE0DHxgljNBAAO9TXL0Y4OHwAAAABJRU5ErkJggg=="^^<http://www.w3.org/2001/XMLSchema#base64Binary> .
+<Patient/ID-11> <Patient#Photo> "aVZCT1J3MEtHZ29BQUFBTlNVaEVVZ0FBQUFVQUFBQUZDQVlBQUFDTmJ5YmxBQUFBSEVsRVFWUUkxMlA1Ly84L3czOEdJQVhESUJLRTBESHhnbGpOQkFBTzlUWEwwWTRPSHdBQUFBQkpSVTVFcmtKZ2dnPT0="^^<http://www.w3.org/2001/XMLSchema#base64Binary> .
 <Patient/ID-12> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <Patient> .
 <Patient/ID-12> <Patient#ID> "12"^^<http://www.w3.org/2001/XMLSchema#integer> .
 <Patient/ID-12> <Patient#FirstName> "Chandler" .
@@ -30,4 +30,4 @@
 <Patient/ID-12> <Patient#BirthDate> "1978-04-06"^^<http://www.w3.org/2001/XMLSchema#date> .
 <Patient/ID-12> <Patient#EntranceDate> "2007-03-12T02:13:14"^^<http://www.w3.org/2001/XMLSchema#dateTime> .
 <Patient/ID-12> <Patient#PaidInAdvance> "true"^^<http://www.w3.org/2001/XMLSchema#boolean> .
-<Patient/ID-12> <Patient#Photo> "iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAYAAACNbyblAAAAHElEQVQI12P5//6/w38GIAXDIBKE0DHxgljNBAAO9TXL0Y4OHwAAAABJRU5ErkJggg=="^^<http://www.w3.org/2001/XMLSchema#base64Binary> .
\ No newline at end of file
+<Patient/ID-12> <Patient#Photo> "aVZCT1J3MEtHZ29BQUFBTlNVaEVVZ0FBQUFVQUFBQUZDQVlBQUFDTmJ5YmxBQUFBSEVsRVFWUUkxMlA1Ly82L3czOEdJQVhESUJLRTBESHhnbGpOQkFBTzlUWEwwWTRPSHdBQUFBQkpSVTVFcmtKZ2dnPT0="^^<http://www.w3.org/2001/XMLSchema#base64Binary> .
\ No newline at end of file
diff -r 5a6368032f1e D018-1table1primarykey2columns3rows/directGraph.ttl
--- a/D018-1table1primarykey2columns3rows/directGraph.ttl	Fri Mar 16 01:33:45 2012 +0100
+++ b/D018-1table1primarykey2columns3rows/directGraph.ttl	Mon Mar 19 12:05:32 2012 -0400
@@ -1,9 +1,9 @@
 _:a <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <Student> .
 _:a <Student#ID> "10"^^<http://www.w3.org/2001/XMLSchema#integer> .
 _:a <Student#Name> "Venus          " .
-_:a <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <Student> .
-_:a <Student#ID> "20"^^<http://www.w3.org/2001/XMLSchema#integer> .
-_:a <Student#Name> "Fernando       " .
-_:a <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <Student> .
-_:a <Student#ID> "30"^^<http://www.w3.org/2001/XMLSchema#integer> .
-_:a <Student#Name> "David          " .
+_:b <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <Student> .
+_:b <Student#ID> "20"^^<http://www.w3.org/2001/XMLSchema#integer> .
+_:b <Student#Name> "Fernando       " .
+_:c <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <Student> .
+_:c <Student#ID> "30"^^<http://www.w3.org/2001/XMLSchema#integer> .
+_:c <Student#Name> "David          " .
# All of these had the same BNode; should be three different BNodes.

-- 
-ericP
Received on Monday, 19 March 2012 17:09:56 UTC