W3C home > Mailing lists > Public > public-qa-dev@w3.org > December 2006

Re: Patch for CSS Validator bug #761

From: olivier Thereaux <ot@w3.org>
Date: Tue, 12 Dec 2006 15:50:19 +0900
Message-Id: <BB465C50-0D51-4C05-A667-91C2A8FB909D@w3.org>
Cc: QA Dev <public-qa-dev@w3.org>
To: Peter Zhelezniakov <Peter.Zhelezniakov@Sun.COM>

He Peter,

On Dec 9, 2006, at 04:17 , Peter Zhelezniakov wrote:
> Here's my patch for Validator bug #761. It's short and simple.  
> Could you
> please review it? XMLStyleSheetHandler is the only file changed  
> since i
> want the new logic to apply to XHTML only.

Looks good, I applied and tested it. Looking at
I noticed that it would be better that the parser should not pass the  
style content within the comments to the CSS parser, so I later  
modified your code to do that, see:

> I tried to enter the patch into Bugzilla but it didn't work for me  
> -- is
> it working at all?

Bugzilla has a bug that becomes unbearable in our setup, indeed.
The solution I had found for it is to
* go to http://www.w3.org/Bugs/Public/
* log out if necessary and go to the login page
* make sure the checkbox for "restrict this session to this IP  
addres" is NOT checked
* log in

You should be rid of the problem.

(The problem comes when you lose authentication between the time you  
go to the attachment page and submit it, and with our setting of  
multiple proxies, it breaks very often)

> Anyway the patch is not complete, it lacks message
> strings for languages other than English (i define a new warning  
> message
> there). How do we go about that?

I copied the english version in all the message properties files, and  
will do a call for translation.

Again, thanks!
Received on Tuesday, 12 December 2006 06:50:24 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 16:54:51 UTC