- From: Arthur Barstow <art.barstow@gmail.com>
- Date: Mon, 01 Dec 2014 17:00:42 -0500
- To: timeless@gmail.com, public-pointer-events@w3.org
[ correcting Josh's e-mail address ]
Hi Josh,
I accepted all of your proposed changes for the following comments: 1-6,
9-11, 14, 17, 18, 20, 22, 24, 25, 29, 30, 32, 33, 35, 37, 38, 40, 42 and
43. Unless we here otherwise from you by December 5, we will assume you
agree with all of these commits. (Commit log below).
Jacob will reply to your other comments.
-Thanks, ArtB
On 11/16/14 1:29 AM, timeless@gmail.com wrote:
> 1. I can't link to the examples, please give them ids.
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#widl-PointerEvent-pointerType
>
>
>> See Example 2 for a basic demonstration of how the pointerType can be
>> used.
> That really wants to link to example 2, but it can't, so it doesn't.
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/c8e5179bf0e5>.
> 2. cancell?able:
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#h2_examples
>
>> EXAMPLE 4: Firing an untrusted pointer event from script
>> var event = new PointerEvent("pointerover",
>> {bubbles: true,
>> cancelable: true,
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#h4_firing-events-using-the-pointerevent-interface
>
>
>> Initialize the cancelable attribute for the event to true if the
>> event name is
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#h4_list-of-pointer-events
>
>
>> Cancellable
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#h_note_20
>
>> Touch manipulations are intentionally not a default action of pointer
>> events.
>> Removing this dependency on the cancellation of events facilitates
>> performance optimizations by the user agent.
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/c4169962f4fb>.
> 3. spellcheck
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#process-pending-pointer-capture
>
>
>> and the hit test node has recieved [sic] pointerover
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/792b06bffee6>.
> 4. w3 is en-us
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#h3_implicit-pointer-capture
>
>
>> Some user agents implement their own implicit pointer capture
>> behaviour [en-gb]
> Note that the document also includes the correct spelling
> (behavior(s)) -- including in the outline.
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/ae628813df81>.
> 5. like/or/a
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#h2_abstract
>
>> This document defines events and related interfaces for handling
>> hardware agnostic pointer input from devices like a mouse, pen, or
>> touchscreen.
> There are a couple of problems with "like"/"or"
> a. "like" implies "like, but not actually", so you're defining events
> for things that are similar to mouse/pen/touchscreen, but don't
> actually include mouse/pen/touchscreen.
> b. "or" bothers me. You should really want to use "and" in your list.
> or end it with "etc."
> c. there's an article "a" for mouse, but you aren't really saying
> "like a specific mouse", you mean mice in general.
>
> I'd probably replace "like" with "including", drop "or" entirely, and
> add "etc." to the end.
>
> ... handling input in a device agnostic way from hardware including
> mouse, pen, touchscreen, etc.
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#intro
>
>> Newer computing devices today, however, incorporate other forms of
>> input, like touchscreens or pen input.
> Same objections to like/or
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/4996823109fc>.
> 6. "other than mouse" is awkward.
>
>> For compatibility with existing mouse based content, this
>> specification also describes a mapping to fire [DOM-LEVEL-3-EVENTS]
>> Mouse Events for pointer device types other than mouse.
> "other than mouse" is awkward.
>
> ... for other pointer device types.
>
> --
> as an asside, I need to ask the Process TF to consider that WGs
> shouldn't be allowed to claim a document has satisfied technical
> requirements if it hasn't been run through a spell checking program.
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/548c384d69e2>.
> 9. this paragraph is hiding important "key goals" in a rather long
> paragraph. that's unfortunate, they should really be bulleted.
>> An additional key goal is to enable multi-threaded user agents to
>> handle default touch actions, such as scrolling, without blocking on
>> script execution.
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/300a07cd7550>.
> 10. active pointer
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#dfn-active-pointer
>
>> In some platforms, the set of active pointers includes all pointer
>> input to the device, including any that are not targeted at the user
>> agent (e.g. another application).
> s/In/On/
> s/another application/those targeted at (captured by?) other
> applications/
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/e62d82b7c96f>.
> 11. digitizer
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#dfn-digitizer
>
>> Most commonly, this is the surface that sense input from touch
>> contact or a pen stylus.
> s/sense/senses/
> s/from/from the/
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/1d3e1fdafca4>.
> 14. pressure
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#widl-PointerEvent-pressure
>
>> the value must be 0.5 when in the active buttons state and 0 otherwise.
> please mark up "active buttons state"
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/bc592d575d98>.
> 17. missing period
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#dfn-fire-an-event-named-e
>
>
>> * Set the relatedTarget attribute of the event to null
>> * Fire the event to the pointer capture target override object.
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/78a147eb6feb>.
> 18. too complicated
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#process-pending-pointer-capture
>
>
>> Further, if the pointer capture target override is not set,
>> the pending pointer capture target override is not equal to the hit
>> test node for the pointer event which invoked this process,
> It's too hard to read this sentence to the end.
> You could either add an "and" after "set, ", or turn the item into a
> bulleted list of conditions.
>
>> and the hit test node has recieved pointerover and pointerenter events,
>> then fire a pointer event named pointerout and a pointer event named
>> pointerleave at the hit test node.
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/a432cd504354>.
> 20. Unclosed paren
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#list-of-pointer-events
>
>
>> In the case of the primary pointer, these events (with the exception
>> of gotpointercapture, and lostpointercapture may also fire
>> compatibility mouse events.
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/2e1fbc9aedf4>.
> 22. Missing word
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#the-pointercancel-event
>
>> After having fired the pointerdown event, the pointer is subsequently
>> used to manipulate the page viewport (e.g. panning or zooming).
> "event, the" -> "event, if the"
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/eae5dcd474e1>.
> 24. mising periods
>> A user agent must fire a pointer event named pointercancel in the
>> following circumstances:
>> * The user agent has determined that a pointer is unlikely to
>> continue to produce events (for example, because of a hardware event).
>> * After having fired the pointerdown event, the pointer is
>> subsequently used to manipulate the page viewport (e.g. panning or
>> zooming).
> Note the periods here.
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#the-pointerout-event
>
> A user agent must fire a pointer event named pointerout when any of
> the following occurs:
>> A pointing device is moved out of the hit test boundaries of an element
>> After firing the pointerup event for a device that does not support
>> hover (see pointerup)
>> After firing the pointercancel event (see pointercancel)
>> When a pen stylus leaves the hover range detectable by the digitizer
> Note the lack of periods here.
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/387aab9bdc37>.
> 25. off/out-of
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#the-pointerleave-event
>
>
>> A user agent must fire a pointer event named pointerleave when a
>> pointing device is moved off of the hit test boundaries of an element
>> and all of its descendants,
> off -> out of ?
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/f3d3f9e07b5f>.
> 29. the provided the method's -- the the the the
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#widl-Element-setPointerCapture-void-long-pointerId
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#widl-Element-releasePointerCapture-void-long-pointerId
>
>
>> Throws a DOMException with the name InvalidPointerId when the
>> provided the method's argument does not match any of the active
>> pointers.
> 1. drop the "the" after "provided".
> 2. make everyone's life better by using "pointerId" instead of not
> naming the argument.
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/b00b0f397de7>.
> 30. is
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#widl-Navigator-maxTouchPoints
>
>
>> For example, suppose a device has 3 touchscreens, which support 2, 5,
>> and 10 simultaneous touch contacts, respectively.
>> The value of maxTouchPoints is 10.
> is -> should be (or something)
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/2849228e6301>.
> 32. period
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#h3_the-touch-action-css-property
>
>
>> Applies to:
>> all elements except: non-replaced inline elements, table rows,
>> row groups, table columns, and column groups
> no period...
>
>> Computed value:
>> Same as specified value.
> period...
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/940c7e26f906>.
> 33. stray space
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#h4_the-primary-pointer
>
>
>> Authors who desire single-pointer interaction can achieve this by
>> ignoring non-primary pointers (however, see the note below on
>> multiple primary pointers) .
> the space after the closing paren is extraneous.
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#h3_the-touch-action-css-property
>
>
>> The touch-action property only applies to elements that support both
>> the CSS width and height properties (see [CSS21] ).
> the space before the closing paren is extraneous.
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/5e966dd54003>.
> 35. missing space
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#implicit-release-of-pointer-capture
>
>
>> Immediately after firing the pointerup or pointercancel events,
>> a user agent must run the steps as if the releasePointerCapture()
>> method has been called with an argument equal to the pointerId
>> property of the pointerup orpointercancel event just dispatched.
> there's a space missing after 'or'.
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/c2cedf0488e0>.
> 37. When, not If
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#implicit-release-of-pointer-capture
>
>
>> If the pointer capture target override is removed from the document
>> tree,
>> clear the pending pointer capture target override and pointer capture
>> target override nodes and
>> fire a Pointer Event named lostpointercapture at the document.
> If -> When
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/a6696cb32a11>.
> 38. Pointer Event or PointerEvent ??
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#implicit-release-of-pointer-capture
>
>
>> If the pointer capture target override is removed from the document
>> tree,
>> clear the pending pointer capture target override and pointer capture
>> target override nodes and
>> fire a Pointer Event named lostpointercapture at the document.
> There are 89 instances of "pointer event" (case insensitive), and 40
> of "PointerEvent" (case sensitive).
>
> This case seems to be one where the latter is more appropriate.
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/4b2e730a0701>.
> 40. the/may
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#dfn-compatibility-mouse-events
>
>
>> The vast majority of web content existing today codes only to Mouse
>> Events.
>> The following describes the algorithm for how a user agent may map
>> generic pointer input to mouse events for compatibility with this
>> content.
> If this is a way for something to happen, then perhaps there are other
> ways in which it may happen. In which case it should not say "the
> alogrithm", but rather "an algorithm".
>
> If this should be the only way, then you'll need to rephrase:
>
> "If a UA wishes to ... then it SHOULD use the following algorithm ..."
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/465f8f2fd207>.
> 42. link and anchor support-hover/do-not-support-hover
>
> there are lots of mentions of "does not support hover", there are
> anchors:
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#mapping-for-devices-that-support-hover
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#mapping-for-devices-that-do-not-support-hover
>
>
> but, things don't link to them:
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#the-pointerover-event
>
>
>> A user agent must fire a pointer event named pointerover when a
>> pointing device is moved into the hit test boundaries of an element.
>> A user agent must also fire this event prior to firing a pointerdown
>> event for devices that do not support hover (see pointerdown).
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/2ba1ccabd2df>.
> 43. missing periods?
>
> http://www.w3.org/TR/2014/WD-pointerevents-20141113/#h3_mapping-for-devices-that-do-not-support-hover
>
>
>> * The input can hover independently of activation (e.g. moving a
>> mouse cursor without any buttons pressed)
>> * The input will likely produce the mousemove event on an element
>> before clicking it
Fixed <https://dvcs.w3.org/hg/pointerevents/rev/3aff09f55902>.
> --
> This review was sent in response to:
> http://lists.w3.org/Archives/Public/public-review-announce/2014Nov/0002.html
>
>
>
Received on Monday, 1 December 2014 22:01:10 UTC