RE: Status of review for PR-324

Hi all,

I've reviewed a bunch of test files and provided my comments at the PR link. I've also provided some general comments.

The following tests were reviewed and IMO require some changes (on top of those from the general comments).
pointercancel.html
pointerevent_pointerEnter_does_not_bubble.html
pointerevent_pointerEnter_noHover.html
pointerevent_pointerLeave_does_not_bubble.html
pointerevent_pointerMove_isPrimary_same_as_pointerDown.html
pointerevent_support.js
pointerevent_pointerType_mouse.html
pointerevent_pointerType_pen.html
pointerevent_pointerType_touch.html
pointerout.html
pointerup.html

The following tests were reviewed as ok, but might require changes as per the general comments.
pointerevent_pointerEnter.html
pointerevent_pointerOver.html

Regards, Cathy.


> -----Original Message-----
> From: Barstow Art (Nokia-CIC/Boston)
> Sent: Monday, October 07, 2013 12:13 PM
> To: public-pointer-events@w3.org
> Subject: Status of review for PR-324
> 
> Cathy and Matt reviewed the following tests Jacob included in [PR-324]
> (thanks Cathy and Matt!):
> 
> Cathy:
> pointercancel.html
> pointerevent_pointerEnter.html
> pointerevent_pointerEnter_does_not_bubble.html
> pointerevent_pointerEnter_noHover.html
> pointerevent_pointerLeave_does_not_bubble.html
> 
> Matt:
> pointerevent_pointerMove_isPrimary_same_as_pointerDown.html
> pointerevent_pointerOver.html
> pointerevent_support.js
> pointerout.html
> pointerup.html
> 
> If anyone else can review the other tests, please do so and include your
> comments to PR-324 (even if just a "+1/OK") :
> 
> capture.html
> pointerevent_gotpointercapture_before_first_pointerevent.html
> pointerevent_releasePointerCapture_events_to_original_target.html
> pointerevent_releasePointerCapture_invalid_pointerId.html
> pointerevent_setPointerCapture_invalid_pointerId.html
> 
> pointerevent_pointerLeave_mouse.html
> pointerevent_pointerLeave_pen.html
> pointerevent_pointerLeave_touch.html
> pointerevent_pointerType_mouse.html
> pointerevent_pointerType_pen.html
> pointerevent_pointerType_touch.html
> 
> -Thanks, AB
> 
> [PR-324] <https://github.com/w3c/web-platform-tests/pull/324>
> 

Received on Monday, 21 October 2013 20:07:48 UTC