- From: Brian Kardell <bkardell@gmail.com>
- Date: Mon, 14 Jan 2013 11:42:05 -0500
- To: Clint Hill <clint.hill@gmail.com>
- Cc: Marcos Caceres <w3c@marcosc.com>, "public-nextweb@w3.org" <public-nextweb@w3.org>
- Message-ID: <CADC=+jcGbGz7hFTkWb3aDho_8OWw_n+T+nBfU6x3eUHM=1OpWQ@mail.gmail.com>
On Mon, Jan 14, 2013 at 11:40 AM, Clint Hill <clint.hill@gmail.com> wrote: > Marcos: I'm glad you showed this as I just committed a Boolean test > fixture. I also used AMD. But we have different approaches (I'm using > require and you use define). I put my test in > "web-idl-type-boolean-tests.js" in the /test directory. > > I think my pattern is a little lighter than yours and might make test > writing a bit easier? > > I'm happy contribute to the test writing as maybe that's a way to get > blind taste tests since I didn't write the implementations? Maybe that > will create a cleaner validation process of the implementations this way. > > Thoughts? > > > On 1/14/13 9:18 AM, "Marcos Caceres" <w3c@marcosc.com> wrote: > > > > > > >On Monday, January 14, 2013 at 4:11 PM, Brian Kardell wrote: > > > >> It isn't a stupid question at all - as I said, they are reworking > >>grunt. Your version was the latest until just a few days ago and there > >>are significant breaking changes including this one. > > > > > >Love it :) Ok, so, I'm going to continue manually linting and testing in > >the browser for now (just to not be held up while that transition goes > >on). > > > >About the tests, I'm still working on them but here is where I'm heading > >with them (example as an AMD module): > > > >http://pastebin.com/AxaAt6eD > > > >This file sits under test/modules/WebIDL.Boolean-tests.js > > > >This makes the tests completely self contained modules that load in their > >own dependencies - which is _really_ nice, IMO. > > > >What I like about this structure is that it allows for pasting in the > >spec text to test(assertion, Š); > > > >Let me know what you guys think! > > > > > >-- > >Marcos Caceres > > > > > > > > > Not that it is worth anything useful to say so, but I did it the same way as clint when I was merging. -- Brian Kardell :: @briankardell :: hitchjs.com
Received on Monday, 14 January 2013 16:42:33 UTC