Re: CreateMasterTestOutput options for moki vs testresults.xml

This done. Now add a third parameter on the command line to update
testresults.xml. "true" is fine.

On Jan 15, 2008 3:19 PM, Sean Owen <srowen@google.com> wrote:
> This was undoubtedly my fault. I typically assume that if I see a
> change, and it seems to be causing a test suite to fail, that maybe
> the person changing it forgot to update the test. But that's not
> always right of course and I should pay more attention to the diff to
> see if it makes sense.
>
> I can add this option -- yes this is a good reason. In fact, I think
> the default should be to not update testresults.xml, since usually we
> will be running this to accommodate changes in moki.xml that are not
> relevant to the test's outcome.
>
>
> On Jan 15, 2008 7:40 AM, Dominique Hazael-Massieux <dom@w3.org> wrote:
> >
> > Hi,
> >
> > I found at least 3 tests this morning whose testresults.xml had been
> > modified in batch after a bug was introduced in the MinimizeTest.xsl,
> > and thus gave false results.
> >
> > Beyond taking more care when making changes to testresults.xml, I think
> > it would help if the CreateMasterTestOutput program could take an option
> > to update only either the moki.xml or the testresults.xml.
> >
> > (the reasoning being that in most cases, one doesn't want to update
> > testresults.xml; moki.xml might need changes more frequently e.g. when
> > we add new stuff in the preprocessing).
> >
> > What do you think?
> >
> > Dom
> >
> >
> >
> >
>

Received on Thursday, 17 January 2008 00:48:40 UTC