Need to correct gUM algorithm's errors from Dan Burnett on 2015-07-07 (public-media-capture@w3.org from July 2015)

From: Dan Burnett <dburnett@voxeo.com>
Date: Tue, 7 Jul 2015 14:42:17 -0400
To: public-media-capture@w3.org
Message-Id: <CDF7842B-EF7E-4AB2-B405-81E83F27F09F@voxeo.com>

When attempting to apply the OverconstrainedError PR (#194), I noticed that the rewrite of the gUM algorithm to use SelectSettings inadvertently changed some of the errors. Specifically, the NotFoundError should have been for the case where no suitable sources were available even before applying constraints, and the ConstraintNotSatisfiedError (which will shortly be changed by PR 194) should have been used for the case where no suitable sources were found after applying constraints, meaning that at least one required constraint could not be satisfied.

I have submitted PR 213 (https://github.com/w3c/mediacapture-main/pull/213) to address this.  I'm looking for only a quick sanity check here by anyone who cares.  I plan to apply the change tomorrow so I can finally get the OverconstrainedError PR (#194) in.

-- dan

Received on Tuesday, 7 July 2015 18:42:41 UTC