W3C home > Mailing lists > Public > public-media-capture-logs@w3.org > January 2017

Re: [mediacapture-main] Revive createObjectURL?

From: Harald Alvestrand via GitHub <sysbot+gh@w3.org>
Date: Wed, 11 Jan 2017 12:44:56 +0000
To: public-media-capture-logs@w3.org
Message-ID: <issue_comment.created-271859431-1484138694-sysbot+gh@w3.org>
@foolip one of the reasons why I hate createObjectURL with a passion 
is that it's very hard to mock it. adapter.js doesn't intercept calls 
to createObjectURL (AFAIK), it only makes sure that setting srcObject 
works even if srcObject is not implemented.
So people using adapter.js and calling createObjectURL(MediaStream) 
will still show up in the stats.

@jan-ivar would we be able to write a createObjectURL shim that worked
 correctly for MediaSource and all other createObjectURL use cases, 
and still intercepted calls with MediaStream parameters?

I'm tempted.

-- 
GitHub Notification of comment by alvestrand
Please view or discuss this issue at 
https://github.com/w3c/mediacapture-main/issues/404#issuecomment-271859431
 using your GitHub account
Received on Wednesday, 11 January 2017 12:45:02 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 16:27:31 UTC