- From: Tomasz Pluskiewicz via GitHub <sysbot+gh@w3.org>
- Date: Tue, 31 Oct 2017 07:56:48 +0000
- To: public-hydra-logs@w3.org
Review status: all files reviewed at latest revision, 13 unresolved discussions.
---
*[drafts/use-cases/5.1.creating-new-event-indirectly.md, line 10 at r1](https://reviewable.io:443/reviews/hydracg/specifications/143#-KxcV7lBobudR-WyuFut:-KxlQFPZMPDwp3hofcpX:b-b1t4d1) ([raw file](https://github.com/hydracg/specifications/blob/f03e3028e6417adf2767a44c0c854b4af3b5fb4d/drafts/use-cases/5.1.creating-new-event-indirectly.md#L10)):*
<details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote>
PUT is not just create and it is not the only way to create a resource so we should spell out here why PUT might be preferable.
</blockquote></details>
Do you have any suggestions?
---
*[drafts/use-cases/5.1.creating-new-event-indirectly.md, line 34 at r1](https://reviewable.io:443/reviews/hydracg/specifications/143#-KxZXSL5Owpv1cqTG5AR:-KxlNMTizTER78qZLtUJ:bb6ywmx) ([raw file](https://github.com/hydracg/specifications/blob/f03e3028e6417adf2767a44c0c854b4af3b5fb4d/drafts/use-cases/5.1.creating-new-event-indirectly.md#L34)):*
<details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote>
Looks good. I'd only change getOperationOfType to getOperation**s**OfType as it always returns an array. You will also need to take the first result of the filter operation (currently operation is still an array).
I would probably also go a step further and also create a method to get rid of that filter statement to have something like
```
memberTemplate
.getOperationsOfType('http://schema.org/CreateAction')
.thatExpect('http://schema.org/Event')
.first();
```
@alien-mcl what do you think about this?
</blockquote></details>
LGTM
---
*[drafts/use-cases/5.1.creating-new-event-indirectly.md, line 42 at r1](https://reviewable.io:443/reviews/hydracg/specifications/143#-KxcW88cm2en7sVc9HI0:-KxlQSieaKxK73l6tL50:bbg3b0s) ([raw file](https://github.com/hydracg/specifications/blob/f03e3028e6417adf2767a44c0c854b4af3b5fb4d/drafts/use-cases/5.1.creating-new-event-indirectly.md#L42)):*
<details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote>
On second thought, I think we should split this off into a separate use case.
</blockquote></details>
If you have some details in mind please create an issue for that use case so that it doesn't escape our attention
---
*[drafts/use-cases/5.1.creating-new-event-indirectly.md, line 64 at r1](https://reviewable.io:443/reviews/hydracg/specifications/143#-KxYcL7VkgLlvZsRJlA4:-KxlQdJp2hLcQqpVOrYI:bamxmsy) ([raw file](https://github.com/hydracg/specifications/blob/f03e3028e6417adf2767a44c0c854b4af3b5fb4d/drafts/use-cases/5.1.creating-new-event-indirectly.md#L64)):*
<details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote>
Let's discuss PUT to a "placeholder URL" in the other comment or, likely better, in a separate use case.
</blockquote></details>
Is that the same use case you mention in a comment above?
---
*[drafts/use-cases/5.1.creating-new-event-indirectly.md, line 78 at r1](https://reviewable.io:443/reviews/hydracg/specifications/143#-KxY28Opn5nMlgaMrFGV-r1-78:-KxlO2QflOakvvqsHYm6:b-9kbmns) ([raw file](https://github.com/hydracg/specifications/blob/f03e3028e6417adf2767a44c0c854b4af3b5fb4d/drafts/use-cases/5.1.creating-new-event-indirectly.md#L78)):*
<details><summary><i>Previously, lanthaler (Markus Lanthaler) wrote…</i></summary><blockquote>
I think it would be very surprising if it wouldn't be added to the collection as the IriTemplate is the memberTemplate of the collection.
</blockquote></details>
There wasn't a `memberTemplate` when Karol asked his question, mind you.
---
*Comments from [Reviewable](https://reviewable.io:443/reviews/hydracg/specifications/143)*
<!-- Sent from Reviewable.io -->
--
GitHub Notification of comment by tpluscode
Please view or discuss this issue at https://github.com/HydraCG/Specifications/pull/143#issuecomment-340687001 using your GitHub account
Received on Tuesday, 31 October 2017 07:56:50 UTC