RE: Submit two test cases for contentEditable and designMode attributes

Hi,

Thanks for feedback by Aryeh Gregor, and now we have modified the cases and submitted them again onto dvcs.w3.org/hg/html/, which could be found in:
[1] http://w3c-test.org/html/tests/submission/Baidu/editing/user-interaction-editing-contenteditable.html
[2] http://w3c-test.org/html/tests/submission/Baidu/editing/user-interaction-editing-designMode.html

We'd like to ask for approval for both of the cases and welcome for your advices and suggestion. Many thanks.

Best Regards,
Pengcheng


--------------------------------------------------------------------------------
Sender: Aryeh Gregor [mailto:ayg@aryeh.name] 
Time: 2012年8月16日 21:53
Receiver: Guo,Pengcheng
CC: public-html-testsuite@w3.org
Subject: Re: Submit two test cases for contentEditable and designMode attributes

On Thu, Aug 16, 2012 at 12:23 PM, guopengcheng <guopengcheng@baidu.com> wrote:
> We’d like to submit two new test cases for HTML5 attributes contentEditable
> and designMode. Could someone help to review them? Many thanks.
>
>
>
> Following is the general info:
>
>
>
> [Case Name]:  contentEditable attribute test
>
> [Case Path]:
> http://w3c-test.org/html/tests/submission/Baidu/editing/user-interaction-editing-contenteditable.html
>
> [Description]:  This test focused on attribute contentEditable, whose rules
> is defined in http://www.w3.org/TR/html5/editing.html#contenteditable
>
>                             Test case covers different input values of this
> attribute, as well as the child elements with this attribute.
>
>
>
> [Case Name]:  designMode attribute test
>
> [Case Path]:
> http://w3c-test.org/html/tests/submission/Baidu/editing/user-interaction-editing-designMode.html
>
> [Description]:  This test focused on attribute designMode, whose rules is
> defined in
> http://www.w3.org/TR/html5/editing..html#making-entire-documents-editable:-the-designmode-idl-attribute
>
>                             Test case covers different input values of this
> attribute.

Thanks for the tests!  Here's some feedback:

1) Please name your tests.  E.g., instead of

   test(function() {
    assert_equals(testElement.contentEditable,"inherit", "check for
testElement.contentEditable value");
   });

do

   test(function() {
    assert_equals(testElement.contentEditable,"inherit", "check for
testElement.contentEditable value");
   }, "no contenteditable attribute");

and maybe call the next one 'contenteditable=""', etc.  Otherwise
their names default to "Editing: contentEditable attribute test",
"Editing: contentEditable attribute test 1", and so on, so it's not
clear what the browser is failing.

2) You name all your asserts "check for testElement.contentEditable
value".  You should call the ones that check isContentEditable "check
for testElement.isContentEditable value" instead.  (This is just a
typo.)


I've reviewed both of your tests, and if you fix those two problems I
support their approval.  Per the current policy
<http://www.w3.org/html/wg/wiki/Testing/Approval/>, it looks like if
no one else has objections, they'll be approved after two conference
call meetings, i.e., about four weeks.

Thanks again for your contribution!

Received on Friday, 17 August 2012 02:44:33 UTC