Re: Request for review/approval of reflection tests

• From: Ms2ger <ms2ger@gmail.com>
• Date: Tue, 08 Mar 2011 22:44:44 +0100
• To: Aryeh Gregor <Simetrical+w3c@gmail.com>
• CC: public-html-testsuite@w3.org
• Message-ID: <4D76A34C.9080704@gmail.com>

Hi Aryeh

On 02/16/2011 02:31 AM, Aryeh Gregor wrote:
> http://aryeh.name/tests-root/tests/submission/AryehGregor/reflection/reflection-onepage.html

I haven't yet done an exhaustive review, but I'd like to note that I 
believe that the test for area@shape is incorrect, as the spec doesn't 
limit that attribute to only known values (AFAICT).

As for reviewing your test, I find it pretty hard to follow. Having to 
follow the chain element->attribute->type->reflectsFoo 
function->reflects function->doReflects function makes it easy to lose 
track what you're reviewing.

Also, there's quite a bit of code with comments suggesting an update 
after the rewrite you did; it might be useful to fix those.

Thanks for your work
Ms2ger

Received on Tuesday, 8 March 2011 21:45:19 UTC