Reviews of some of Philip Taylor's canvas tests

Hi all

I've reviewed some of Philip's tests:

2d.composite.globalAlpha.image.html
2d.composite.globalAlpha.canvas.html
2d.composite.globalAlpha.imagepattern.html
2d.composite.globalAlpha.canvaspattern.html
2d.composite.solid.source-over.html
2d.composite.solid.destination-over.html
2d.composite.solid.source-in.html
2d.composite.solid.destination-in.html
2d.composite.solid.source-out.html
2d.composite.solid.destination-out.html
2d.composite.solid.source-atop.html
2d.composite.solid.destination-atop.html
2d.composite.solid.xor.html
2d.composite.solid.copy.html
2d.composite.solid.lighter.html
Approved.

2d.composite.transparent.source-over.html
Approved with s/218/219/.

2d.composite.transparent.destination-over.html
Approved with s/145/146/.

2d.composite.transparent.source-in.html
2d.composite.transparent.destination-in.html
2d.composite.transparent.source-out.html
All approved with s/95/96/.

2d.composite.transparent.destination-out.html
Approved with s/31/32/.

2d.composite.transparent.source-atop.html
Approved with s/63/64/ and s/127/128/.

2d.composite.transparent.destination-atop.html
Approved with s/127/128/g.

2d.composite.transparent.xor.html
Approved with s/63/64/ and s/127/128/.

2d.composite.transparent.copy.html
Approved.

2d.composite.transparent.lighter.html
Approved with s/127/128/.

2d.composite.image.source-over.html
approved with s/218/219/.

2d.composite.image.destination-over.html
approved with s/145/146/.

2d.composite.image.source-in.html
2d.composite.image.destination-in.html
2d.composite.image.source-out.html
All approved with s/95/96/.

2d.composite.image.destination-out.html
Approved with s/31/32/.

2d.composite.image.source-atop.html
Approved with s/63/64/ and s/127/128/.

2d.composite.image.destination-atop.html
Approved with s/127/128/g.

2d.composite.image.xor.html
Approved with s/63/64/ and s/127/128/.

2d.composite.image.copy.html
Approved.

2d.composite.image.lighter.html
Approved with s/127/128/.

2d.composite.canvas.source-over.html
approved with s/218/219/.

2d.composite.canvas.destination-over.html
approved with s/145/146/.

2d.composite.canvas.source-in.html
2d.composite.canvas.destination-in.html
2d.composite.canvas.source-out.html
All approved with s/95/96/.

2d.composite.canvas.destination-out.html
Approved with s/31/32/.

2d.composite.canvas.source-atop.html
Approved with s/63/64/ and s/127/128/.

2d.composite.canvas.destination-atop.html
Approved with s/127/128/g.

2d.composite.canvas.xor.html
Approved with s/63/64/ and s/127/128/.

2d.composite.canvas.copy.html
Approved.

2d.composite.canvas.lighter.html
Approved with s/127/128/.

Review notes for the 2d.composite.transparent.* ones are available. [1]

Ms2ger

[1] http://ms2ger.freehostia.com/tests/notes/canvas.pd.pdf

Received on Monday, 15 November 2010 15:01:40 UTC