W3C home > Mailing lists > Public > public-fx@w3.org > October to December 2014

Re: [web-animations] Wrong AnimationPlayer attributes and typos

From: Сергей Грехов <sgrekhov@unipro.ru>
Date: Wed, 15 Oct 2014 15:48:18 +0700
Message-ID: <873f077efc8458d5cc57245046b3d1bf.squirrel@unipro.ru>
To: "Brian Birtles" <bbirtles@mozilla.com>
Cc: public-fx@w3.org, dom@unipro.ru
Thank you Brian.

But player.source.localTime is wrong anyway because source attribute
returns AnimationNode which has no localTime (as its descendants)

There should be player.source.computedTiming.localTime

> On 2014/10/15 15:55, "Сергей Грехов" wrote:
>> Hi there,
>>
>> Take a look at 5.25. Script execution and live updates to the model
>> (http://w3c.github.io/web-animations/#script-execution-and-live-updates-to-the-model).
>> There is Non-normative section with the EXAMPLE 18
>>
>>        // Initially player.src.localTime is 3000
>>        player.currentTime += 2000;
>>        alert(player.src.localTime); // Displays ‘5000’
>>
>> AnimationPlayer interface has no .src attribute, it has .source
>> attribute
>> that returns AnimationNode which has no .localTime either.
>>
>> And a couple of typos.
>>
>> 3.5.15. Speed control
>> (http://w3c.github.io/web-animations/#speed-control)
>> ...
>> Setting a player’s playback rate to zero effectively pauses the player
>> b(however, the play state does not necessarily become paused).
>>
>> Note 'b' letter before parenthesis
>>
>> 3.5.15.1. Updating the playback rate of a player
>> (http://w3c.github.io/web-animations/#updating-the-playback-rate-of-a-player)
>> ...
>> The procedure to update the player playback rate of a player, player to
>> new playback rate is as followsL
>>
>> Note 'L' at the string end
>
> Thanks Sergey, I've made these fixes to the spec:
>
>
> https://github.com/w3c/web-animations/commit/d612da51ee0ce11437924c61b5a3eb1ab2875b56
>
> I'll look into the start time changes later this week or early next week.
>
> Thanks,
>
> Brian
>
Received on Wednesday, 15 October 2014 08:51:02 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:49:52 UTC