Please help review new added Vibration tests

Hi Anssi & all,

I just created some Vibration tests at https://github.com/w3c/web-platform-tests/pull/1224, please help review them.

http://w3c-test.org/submissions/1224/vibration/cancel-when-hidden-manual.html
http://w3c-test.org/submissions/1224/vibration/invalid-values.html

These tests shall fulfill the gaps mentioned by the TODO.txt reflecting the latest spec.

http://w3c-test.org/submissions/1224/vibration/cancel-with-array-0-manual.html

This test shall address the feedback at

http://lists.w3.org/Archives/Public/public-device-apis/2014Jul/0059.html

... of treating navigator.vibrate([0]) as a cancellation, which is also added into the latest spec.

Thanks,
Zhiqiang


> -----Original Message-----
> From: Kostiainen, Anssi
> Sent: Friday, August 22, 2014 15:59
> To: Zhang, Zhiqiang
> Cc: W3C Device APIs WG
> Subject: Re: Vibration test update (Re ACTION-701: DAP testing status)
> 
> On 22 Aug 2014, at 06:51, Zhang, Zhiqiang <zhiqiang.zhang@intel.com> wrote:
> 
> > Sorry for missing this mail.
> >
> >> From: Kostiainen, Anssi
> >> Sent: Friday, August 08, 2014 16:38
> >> To: Zhang, Zhiqiang
> >> Cc: W3C Device APIs WG
> >> Subject: Re: Vibration test update (Re ACTION-701: DAP testing status)
> >>
> >> Hi Zhiqiang,
> >>
> >> On 14 Jul 2014, at 10:19, Zhang, Zhiqiang <zhiqiang.zhang@intel.com>
> wrote:
> >>
> >>> ... we still miss tests for
> >>>
> >>>   - do nothing when hidden
> >>>   - cancel when dynamically hidden
> >>>   - reinstate when dynamically shown
> >>>   - invalid values
> >>>
> >>> If you have tests for these checkpoints or want to write some, feel free
> to
> >> submit them to
> >>>
> >>> https://github.com/w3c/web-platform-tests/tree/master/vibration
> >>
> >> Please feel free to write test cases for these (I guess "reinstate..." can be
> >> dropped due to changes in the spec since the TODO was written), I'm
> happy
> >> to review them.
> >
> > OK, thank you. I will create some tests soon.
> 
> Thanks for volunteering. If you have any questions, please ping this list.
> 
> All - feel free to review the existing test suite, and suggest additional test
> cases to be added to the above list if you identify further testable assertions.
> 
> >> As discussed, despite you being the Test Facilitator, we can still relax the
> >> rules in such a way that also you can write tests as long as someone else
> >> reviews them before you integrate them.
> >
> > Absolutely yes.
> 
> Thanks,
> 
> -Anssi

Received on Tuesday, 2 September 2014 08:10:48 UTC