- From: Tab Atkins Jr. <jackalmage@gmail.com>
- Date: Thu, 24 Jan 2013 11:15:17 -0800
- To: Anssi Kostiainen <anssi.kostiainen@nokia.com>
- Cc: "ext Frederick.Hirsch@nokia.com" <Frederick.Hirsch@nokia.com>, public-device-apis <public-device-apis@w3.org>
On Thu, Jan 24, 2013 at 1:00 AM, Anssi Kostiainen <anssi.kostiainen@nokia.com> wrote: > Hi Tab, > > On 23.1.2013, at 18.39, ext Tab Atkins Jr. wrote: > >> The empty string needs to be added to the actual enum declaration as well, not just the description of the enum values. Once that is done, you can consider my comments resolved and close this issue. > > The enum declaration was updated as well, the diff was about the source. Sorry about the confusion, I should have included a link to the spec as well: > > http://dvcs.w3.org/hg/dap/raw-file/tip/light/Overview.html > > I did some additional editorial changes. I moved enum LightLevelState value descriptions (such as "dim" corresponds to "direct sunlight" etc.) to a note within the "fire a light level event" algorithm. Previously these were in a separate legacy DOM-style section which was removed as we migrated to a modern authoring style. I also reordered the enum values into more logical order: > > https://dvcs.w3.org/hg/dap/rev/0d5d6f5a952c > > We'll close this issue if we don't hear any further concerns. Ah, I see. Well, it looks great now, and I like the editorial change. All my comments have been addressed, thanks! ~TJ
Received on Thursday, 24 January 2013 19:16:04 UTC