- From: Raphael Kubo da Costa via GitHub <sysbot+gh@w3.org>
- Date: Mon, 13 May 2024 16:16:58 +0000
- To: public-device-apis-log@w3.org
> 1. I find it a bit strange that the creation of the virtual source also defines the sample array. > Should we restrict the creation to only create the virtual source? That would allow the user to control when the updates actually happen. This ended up being fixed a while ago. > 2. Also we don't have a getter version, so we cannot check what was the set samplingInterval at creation. > Should we have one Getter returning the existing virtual sources and their set samplingInterval? Getters are tricky because the information they return might be outdated by the time it reaches users. Unless really needed, I don't think we need to provide ways to access this information (which should be available to users anyway given that they made the WebDriver calls). > 3. Should we have an example to show what needs to be done to for example set a new samplingInterval to a virtual source? Since apparently the virtual source needs to be deleted first? (right?) If we take the "let users handle the sampling rate" approach I mentioned in one of the inline comments, this might end up becoming a non-issue as a side-effect. -- GitHub Notification of comment by rakuco Please view or discuss this issue at https://github.com/w3c/compute-pressure/pull/265#issuecomment-2108130163 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Monday, 13 May 2024 16:16:59 UTC