Re: [screen-wake-lock] Add doc is fully active check (#367)

> Speaking of moving the existing check, https://github.com/w3c/screen-wake-lock/pull/367#discussion_r1448320506 that "the fully active check should be done first". Could you elaborate a bit? I remember asking ages ago if there was a recommended order for the permissions policy + permissions API checks in general, but thought it didn't matter if the fully active ones came before or after those.

Sure. Without a document (or the document being `null` or an iframe being detached) the permission check doesn't make sense - so, basically the fully active check just confirms the document is something in the web page and not just a dangling reference that didn't get garbage collected or accidentally stored in a variable. 



-- 
GitHub Notification of comment by marcoscaceres
Please view or discuss this issue at https://github.com/w3c/screen-wake-lock/pull/367#issuecomment-2044045111 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Tuesday, 9 April 2024 02:31:34 UTC