Re: [screen-wake-lock] Need maximum screen brightness mode (#129)

Great write-up @willmorgan. Thinking about this dimmable option, would it perhaps be better to have two config options, `brightness` and `dimmable` or even `dimTimeout` where the brightness level would be some value like "default", etc and then `dimmable` or `dimTimeout` either a bool or integer respectively to indicate you want or don't want dimming behavior? It feels like an extra option removes some ambiguity and gives a bit more control to the developer. Rather than equivalent constants of "full brightness with dimming", "full brightness without dimming", etc you can just pick "full" with a timeout of `30000` to indicate when to reduce the brightness.

-- 
GitHub Notification of comment by dhensby
Please view or discuss this issue at https://github.com/w3c/screen-wake-lock/issues/129#issuecomment-817853989 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Monday, 12 April 2021 14:20:34 UTC