W3C home > Mailing lists > Public > public-device-apis-log@w3.org > October 2019

Re: [wake-lock] Add an "if aborted" step to WakeLock.request() to deal with hidden documents (#234)

From: Raphael Kubo da Costa via GitHub <sysbot+gh@w3.org>
Date: Fri, 11 Oct 2019 16:40:17 +0000
To: public-device-apis-log@w3.org
Message-ID: <issue_comment.created-541137397-1570812016-sysbot+gh@w3.org>
> Why can't this be part of the abort steps?

It is, in the sense that this condition still causes things to abort. The part I'm adding deals with what to do if this condition actually causes things to abort -- as I explained in the PR message, it's broken/inconsistent at the moment.

I'm not entirely sure this is the best way to fix it though.

GitHub Notification of comment by rakuco
Please view or discuss this issue at https://github.com/w3c/wake-lock/pull/234#issuecomment-541137397 using your GitHub account
Received on Friday, 11 October 2019 16:40:19 UTC

This archive was generated by hypermail 2.4.0 : Monday, 4 July 2022 12:47:57 UTC