- From: Pavel Laptev via GitHub <sysbot+gh@w3.org>
- Date: Sun, 13 Aug 2023 23:39:22 +0000
- To: public-design-tokens-log@w3.org
I can agree with @justinfagnani
1. There shouldn't be any case like a group with the name `value`. In my view, it's a wrong JSON file. I mean it's also possible if someone will call a group `$value`.
```json
{
"value": {
"description": "This is an example of a group containing a nested group",
"tokens": {
"subgroup_of_tokens": {
"token_1_name": {
"type": "color",
"value": "#aabbcc"
},
"token_2_name": {
"type": "color",
"value": "#ddeeff"
}
}
}
}
}
```
2. even then, there shouldn't be any collisions because each `token` object contains a `type` property, so I can check if `value.type` exists.
--
GitHub Notification of comment by PavelLaptev
Please view or discuss this issue at https://github.com/design-tokens/community-group/issues/225#issuecomment-1676496552 using your GitHub account
--
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Sunday, 13 August 2023 23:39:23 UTC