- From: Kyle Wanamaker via GitHub <sysbot+gh@w3.org>
- Date: Wed, 13 Jul 2022 19:00:24 +0000
- To: public-design-tokens-log@w3.org
> > With an object, $deprecated could then resemble other objects in the spec.
>
> This I do not really follow :) Why would `com.my-co.lifecycle` have the need to set `sunset`?
>
The argument is for `$deprecated` to be an object with an `$extensions` property. `com.my-co.lifecycle` is an example only.
The specifics within `$extensions` are a response to [your comment](https://github.com/design-tokens/community-group/issues/118#issuecomment-1150730491) where `$deprecated` could take a `$status` and to @danieldelcore's [comment using states](https://github.com/design-tokens/community-group/issues/118#issuecomment-1155825619) `Experimental → Active → Deprecated → Sunset → Deleted`.
> A `$description` is interesting but I think it might be easier to implement in tools if `$description` is used (for now) to write extra information like this.
>
> ```json
> {
> "Button background": {
> "$type": "...",
> "$value": "...",
> "$description": "Bright pink background for buttons.\nThis has been deprecated.\nSee : <some link> for more info."
> "$deprecated": {
> "$value": true,
> "$future-thing": "..."
> }
> }
> }
> ```
A description and a deprecation notice are separate concepts, IMO. Consider [`@deprecated` in Javadoc][(https://docs.oracle.com/javase/7/docs/technotes/guides/javadoc/deprecation/deprecation.html#javadoc_tag), [`@available` attribute in Swift](https://docs.swift.org/swift-book/ReferenceManual/Attributes.html#ID583), the [`[[deprecated]]` attribute in C++`](https://en.cppreference.com/w/cpp/language/attributes/deprecated), etc.
For those examples, the deprecation message is separate from the implementation. IMO, a separate deprecation message lends toward a better version control history.
--
GitHub Notification of comment by KyleWpppd
Please view or discuss this issue at https://github.com/design-tokens/community-group/issues/118#issuecomment-1183572881 using your GitHub account
--
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Wednesday, 13 July 2022 19:00:25 UTC