Re: file version to demonstrate flakiness bug in Pychinko with no bNodes at all:

Yarden Katz wrote:

>
>Hey,
>
>  Good eye - this is a bug that we had in an older version that was
>  accidently reintroduced.  It is easy to fix -- I will update SVN
>  soon.
>
>Thanks a lot.  
>  
>
This looks like the fix to me. I hope it's useful.

syosi@mr-burns:~/pychinko/pychinko$ svn diff nodes.py
Index: nodes.py
===================================================================
--- nodes.py    (revision 4613)
+++ nodes.py    (working copy)
@@ -187,7 +187,7 @@
             if isinstance(self.lnode, AlphaNode):
                 key = removedups(self.lnode.svars + self.lnode.vars +
self.rnode.vars)
             elif isinstance(self.lnode, BetaNode):
-                key = self.pattern
+                key = removedups(self.lnode.pattern + self.rnode.vars)
         for i, v in enumerate(key):
             bindings[v] = row[i]
         return bindings


-----------------------------------------

Yosi

Received on Thursday, 25 August 2005 20:38:08 UTC