[css-backgrounds-3] background-size-035 to reconsider, to revisit

xiaochun, Jinlong Zhang

[test, nightly-unstable]
http://test.csswg.org/suites/css-backgrounds-3_dev/nightly-unstable/html4/background-size-035.htm

[test, src]
http://test.csswg.org/source/css-backgrounds-3/background-size-035.html


1-
Can you please re-visit background-size-035 test and make sure that the 
test is correct? I believe that test is incorrect; the test will pass 
only and only when the window viewport size is 295px wide by 289px tall.

line 18:  background-attachment:fixed;

If 'background-attachment' is 'fixed', then the background positioning 
area is, by definition, the window content area viewport and not the 
size of <div class="backgroundSize">.

https://www.w3.org/TR/css3-background/#the-background-attachment

2-
line 9: <meta name="assert" content="The test passes if we can see the 
background-image is exactly same as above.">
line 26:  <p>The test passes if we can see the background-image is 
exactly same as above.</p>

Ideally, we want the test assert to explain what is being tested and why 
the layout is what it is. The pass-fail-conditions sentence should 
describe how or when the test passes or fails. In your test, the 
pass-fail-conditions sentence is correct. The text assert is not 
suitable.

3-
When a test compares 2 images, best is to put them side-by-side if they 
have a certain height (greater than 200px): we want to reduce 
occurences, possibilities of vertical scrolling.

The test harness registered a pass for that test most likely, most 
probably because the test started with the reference and not the test. 
Right now, all mainstream browsers (IE11, Edge, Firefox 40+, Chrome 50+) 
fail that test.

4-
line 24: <img src="support/bg.jpg" />

background image filename should be short, descriptive and should try to 
be helpful. A better filename here would have been something like:
sheep-295w-289h.png
or
white-sheep-295w-289h.png


We *prefer* png although we can accept jpg, I suppose, in some cases.

We recommend to reuse already created and available support images for 
tests. Reusing already created support images reduces number of files.

5-
The <div class="container"> does not seem needed or required by the test 
itself. It is not clear what such auto-height and auto-width <div> 
container is supposed to do in the test.

Gérard
-- 
Test Format Guidelines
http://testthewebforward.org/docs/test-format-guidelines.html

Test Style Guidelines
http://testthewebforward.org/docs/test-style-guidelines.html

Test Templates
http://testthewebforward.org/docs/test-templates.html

CSS Naming Guidelines
http://testthewebforward.org/docs/css-naming.html

Test Review Checklist
http://testthewebforward.org/docs/review-checklist.html

CSS Metadata
http://testthewebforward.org/docs/css-metadata.html

Received on Wednesday, 28 September 2016 00:00:43 UTC