W3C home > Mailing lists > Public > public-css-testsuite@w3.org > April 2016

Re: margin-collapse-021

From: Gérard Talbot <css21testsuite@gtalbot.org>
Date: Tue, 05 Apr 2016 17:03:46 -0400
To: Ms2ger <ms2ger@gmail.com>
Cc: Public CSS test suite mailing list <public-css-testsuite@w3.org>
Message-ID: <f44a569d3aad47fa89f1fcbfe3154ee5@gtalbot.org>
Le 2016-04-05 06:05, Ms2ger a écrit :
> Hey Gérard,
> 
> I had a question about
> css21/margin-padding-clear/margin-collapse-021.xht [1],

XHTML version:
[src]
http://test.csswg.org/source/css21/margin-padding-clear/margin-collapse-021.xht

HTML version:
http://test.csswg.org/suites/css21_dev/nightly-unstable/html4/margin-collapse-021.htm


> and since you're
> listed as the reviewer, I guessed you'd be the best person to ask.
> 
> The assertion states "For HTML pages the 'body' element's margins
> collapse.", but I can't find anything in the linked section [2] that
> backs that up. Could you give me a pointer?

Ms2ger, you are correct. There is nothing in the linked section backing 
this up. What's wrong is the "For HTML pages" chunk and the HTMLonly 
flag. That test is not perfectly coherent.

First, for XHTML documents, the body element's margin collapses too. So, 
the HTMLonly flag should not be in that test. The test was most likely 
created to verify that, since "Margins of the root element's box do not 
collapse.", then such exclusion, such restriction does not apply to its 
first child element, which is the body element.

Second, the [src] file was an XHTML document and was submitted with the 
HTMLonly flag... which is inherently contradictory.

Third, the test declares the Ahem font but, as created, there is no need 
to resort, to use the Ahem font in that test. Nowhere the Ahem glyphs 
are being used in that test. So, "font: 20px/1em serif;" instead of 
"font: 20px/1em Ahem;" could have been declared.

Ms2ger, I modified the test only in relation to the incorrect HTMLonly 
flag:

http://hg.csswg.org/test/rev/4089c830b885

Gérard

> 
> Thanks
> Ms2ger
> 
> [1]
> https://github.com/w3c/csswg-test/blob/96d614aa6b1d195b89cb00c4c6f8476ccf910a25/css21/margin-padding-clear/margin-collapse-021.xht
> [2] https://www.w3.org/TR/CSS21/box.html#collapsing-margin

-- 
Test Format Guidelines
http://testthewebforward.org/docs/test-format-guidelines.html

Test Style Guidelines
http://testthewebforward.org/docs/test-style-guidelines.html

Test Templates
http://testthewebforward.org/docs/test-templates.html

CSS Naming Guidelines
http://testthewebforward.org/docs/css-naming.html

Test Review Checklist
http://testthewebforward.org/docs/review-checklist.html

CSS Metadata
http://testthewebforward.org/docs/css-metadata.html
Received on Tuesday, 5 April 2016 21:04:20 UTC

This archive was generated by hypermail 2.4.0 : Friday, 20 January 2023 19:58:21 UTC