Re: CSS Grid Layout tests suite

On Oct 22, 2014, at 9:19 AM, Manuel Rego Casasnovas <rego@igalia.com> wrote:

> Hi all,
> 
> Igalia is implementing the CSS Grid Layout spec in Blink and WebKit, so
> we're interested in contributing to the W3C grid layout tests suite.
> 
> I've been checking its status and there're just a few basic tests, most
> of them marked as pending review in Shepherd [1] (as they were merged as
> unreviewed during the repository reorganization).
> In addition, the syntax is outdated. I've been doing some simple
> pull-requests to fix that (before I realized that they were unreviewed),
> but it seems that the tests should be reviewed first.
> 
> We have just started contributing to the W3C tests suite and, despite
> all the great documentation available at http://testthewebforward.org/,
> we still have some questions/doubts:
> 
> * Review patches:
>  Probably having one of the spec editors (Tab or fantasai) helping to
> review the patches would be the best option to create a good tests suite
> for grid.
>  Other option could be having one of the people with more experience in
> the W3C tests suite helping with the reviews.
>  We understand that if this is not possible, as we have 3 people
> implementing this feature, we could review our own patches. But,
> initially it doesn't seem like the best approach.
> 
> * Land patches:
>  The next step, once a patch is reviewed in a pull-request, would be to
> actually commit it in the mercurial repository (not sure if that's
> automatically done once a pull-request is merged).

The Mercurial and GitHub repos are automatically synced bi-directionally, so if a pull request is merged it will show up in Mercurial within minutes.

>  Anyway, I didn't find any information about how this process should be
> done or how someone could get write permissions on any of the
> repositories (mercurial or github) if needed.

There are a small number of people with write permissions on GitHub, mostly those with approval rights (since merging a pull request implies approval).

Anyone with an account on Shepherd can request write access to the Mercurial repo in the user menu (upper right corner), select “Repository Access”.

Peter

> 
> Any feedback regarding these topics will be more than welcomed.
> 
> Thank you very much,
>   Rego
> 
> [1] http://test.csswg.org/shepherd/search/spec/css-grid-1/
> 
>