Re: CSS3 writing-modes inline-alignment test suites

Le Sam 23 février 2013 3:42, 塩澤 å…ƒ (Shiozawa, Hajime) a écrit :
> Hello Gérard,

Hello Hajime :)


> Thank you for your useful information :-)
>
> I have submitted some changes of tests.
> http://hg.csswg.org/test/rev/a2895f1bcaee
>
> [changes]
>   1. change titles more shortly.
>   2. split text-baseline-00{2|3}.xht into four subtests
> (text-baseline-00{2|3}-{rl|lr}.xht).
>   3. use Ahem font (size 0.5em) and vertical-align property 'text-top'
> for testing central baseline.
>
> What do you think about changes 3?

Except for 'vertical-align: text-top', these changes are okay with me.


More:

1.
In all your tests which uses an image (horizontal or vertical blue
line), you should add the "image" flag:

"image 	Requires support for bitmap graphics and the graphic to load"
http://wiki.csswg.org/test/format#requirement-flags

so, eg in

http://test.csswg.org/source/contributors/hshiozawa/submitted/css3-writing-modes/text-baseline-001.xht

<meta name="flags" content="image" />


2.
In
http://test.csswg.org/source/contributors/hshiozawa/submitted/css3-writing-modes/text-baseline-003-lr.xht

<meta name="flags" content="font ahem" />

"font" flag would be okay if the test was requiring a special font like
an IPA Japanese font. Here, in text-baseline-003-lr.xht, the test only
requires the Ahem font and we have the "ahem" flag for that special
font.

So, please replace
<meta name="flags" content="font ahem" />
with
<meta name="flags" content="ahem image" />

3.
In
http://test.csswg.org/source/contributors/hshiozawa/submitted/css3-writing-modes/text-baseline-003-lr.xht

      .half {
line 33: vertical-align: text-top;
        font-size: 0.5em;
      }

Since the line box height is 1, there is no point in using text-top.

Please replace
line 33: vertical-align: text-top;
with
line 33: vertical-align: top;


4.
In
http://test.csswg.org/source/contributors/hshiozawa/submitted/css3-writing-modes/text-baseline-003-lr.xht

In order to help reviewers and examiners, you may want to replace the Xs
with something more meaningful in source code: don't worry, the glyphs
will be the same: black squares of 20px by 20px.

I suggest to replace

      <p class="mixed"><span class='half'>XXXXXXXXXX</span><img
src="./support/blue-vert-line_1x220.png" alt="Image download
support must be enabled" /></p>
      <p class="upright"><span class='half'>XXXXXXXXXX</span><img
src="./support/blue-vert-line_1x220.png" alt="Image download
support must be enabled" /></p>

with

      <p class="mixed"><span class='half'>TOrieMixed</span><img
src="./support/blue-vert-line_1x220.png" alt="Image download
support must be enabled" /></p>
      <p class="upright"><span class='half'>TOrUPright</span><img
src="./support/blue-vert-line_1x220.png" alt="Image download
support must be enabled" /></p>

Eg:
http://test.csswg.org/suites/css2.1/nightly-unstable/html4/border-padding-bleed-001.htm
http://test.csswg.org/suites/css2.1/nightly-unstable/html4/vertical-align-117a.htm


5.
line 14 : div > p > img {

can be trimmed down to

line 14: img {



Hajime,

I wish I could give you more feedback on your tests. Right now, I am not
very familiar or confident enough with writing-modes *and*
text-orientation values...  I would have to examine more and examine
carefully the specification. I believe your tests are correct but, at
this point, you should get a better reviewer than me :)

One other thing your tests will need: correspondent, associated reftests.

At some point, I believe you should get feedbacks, comments from Koji
Ishii or Elika "fantasai" Etemad about all your tests.


>
> I would like to submit other tests If tests which I've already
> submitted have no problem...
>

Yes, please go ahead: submit your other tests.

Please note that I will be on vacation starting Sunday february 24th for
10-12 days.

Gérard
-- 
Contributions to the CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/

CSS 2.1 Test suite RC6, March 23rd 2011:
http://test.csswg.org/suites/css2.1/20110323/html4/toc.html

CSS 2.1 test suite harness:
http://test.csswg.org/harness/

Contributing to to CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html

Received on Saturday, 23 February 2013 09:45:59 UTC