- From: Gérard Talbot <css21testsuite@gtalbot.org>
- Date: Thu, 8 Nov 2012 21:41:21 -0500
- To: "Zhang, Zhiqiang" <zhiqiang.zhang@intel.com>
- Cc: "Public CSS testsuite mailing list@w3.org" <public-css-testsuite@w3.org>, "Santos, Thiago" <thiago.santos@intel.com>, "Zhang, Haili" <haili.zhang@intel.com>, "Yu, Ling L" <ling.l.yu@intel.com>, "Yang, Lei A" <lei.a.yang@intel.com>
Le Jeu 8 novembre 2012 21:15, Zhang, Zhiqiang a écrit : >> Zhiqiang, >> >> One important pass/fail conditions in this test is about partially >> displayed images or clipped (sliced) images. The pass/fail conditions >> sentences should state that partially displayed cat images or sliced >> images must be considered as a test failure. >> >> Also, "2x2 cat image" may be a bit confusing to some people... >> furthermore if "image" in that sentence is singular, not plural. Hmm.. >> And a single <img> could have 2 cats. >> >> >> How about >> >> Test passes if there is 2 rows of 2 cat images, with no clipped >> (sliced) >> cat image and no red. >> >> or >> >> Test passes if there is 2 rows of 2 cat images and if there is no >> clipped (sliced) cat image and no red. >> >> >> Another idea is to drop the reference to "image" and remove the usage >> of >> the word "image" in such sentence. This is furthermore relevant >> because >> it is often impossible to know how many <img> there are in a webpage >> without examining the source code. So, >> >> >> >> Test passes if there is 2 rows of 2 cats, with no clipped (sliced) cat >> and no red. >> >> or >> >> Test passes if there is 2 rows of 2 cats and if there is no clipped >> (sliced) cat and no red. >> Another formulation which could be better, I think, is: <p>Test passes if there are 2 rows of 2 fully displayed cats, if there is no partially displayed cat and <strong>no red</strong>.</p> ... or maybe <p>Test passes if there are 2 rows of 2 cats, if there is no partially displayed cat and <strong>no red</strong>.</p> because "clipped" and "sliced" are okay to qualify, to describe an image but not a "cat". > > Totally agree, thank you very much for your review feedback. Updated at > > https://hg.csswg.org/test/rev/2263f88caae8 > > Please check it and add your review line. > > I'll update other tests which used cat image. http://test.csswg.org/shepherd/search/testcase/changeset/4748/ > Another, I added one test to check background-repeat 'round' value, > because I found currently no browser supports this feature IE 10 and Opera 12.10 support 'background-repeat: round'. At least, they both pass this background-repeat-round-001.html test. Zhiqiang, let me know if you have more tests (and which tests) to review, to approve. Gérard -- Contributions to the CSS 2.1 test suite: http://www.gtalbot.org/BrowserBugsSection/css21testsuite/ CSS 2.1 Test suite RC6, March 23rd 2011: http://test.csswg.org/suites/css2.1/20110323/html4/toc.html CSS 2.1 test suite harness: http://test.csswg.org/harness/ Contributing to to CSS 2.1 test suite: http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
Received on Friday, 9 November 2012 02:41:55 UTC