- From: Gérard Talbot <css21testsuite@gtalbot.org>
- Date: Fri, 2 Mar 2012 17:29:48 -0500
- To: "Public CSS testsuite mailing list" <public-css-testsuite@w3.org>
Hello, http://test.csswg.org/suites/css2.1/20110323/html4/vertical-align-112.htm http://test.csswg.org/suites/css2.1/20110323/html4/vertical-align-113.htm http://test.csswg.org/suites/css2.1/20110323/html4/vertical-align-114.htm http://test.csswg.org/suites/css2.1/20110323/html4/vertical-align-117.htm http://test.csswg.org/suites/css2.1/20110323/html4/vertical-align-118.htm http://test.csswg.org/suites/css2.1/20110323/html4/vertical-align-119.htm http://test.csswg.org/suites/css2.1/20110323/html4/vertical-align-120.htm http://test.csswg.org/suites/css2.1/20110323/html4/vertical-align-121.htm After examining carefully all 8 tests, I think we should redo those tests so that they all use a font-size value which can be divided by factors 5 and 2 without remaining or fractional pixels. font-size: 0.5in (48px) and font-size: 2em (32px) are not best. Eg. http://test.csswg.org/suites/css2.1/20110323/html4/vertical-align-112.htm The descent space is 9.6px tall for #span1 while it is 28.8px tall for #span2 Eg. http://test.csswg.org/suites/css2.1/20110323/html4/vertical-align-114.htm #span1 alignment line is (48px / 2 ) - (48px * 0.8 / 2) = 5.2px offset. vertical-align-114 diverge from the relative positioning used in 112. So, it makes it furthermore difficult to understand the logic. I propose to replace font-size with 60px in vertical-align-112 and vertical-align-114 tests. Eg. vertical-align-121: 2em (which is 32px) is also cumbersome for precise vertical positioning as such number is not dividable by 5 and by 2 without remainers or fractions. The most important reason is accurately determining baseline line position for glyphs without pixel fraction. The tests also mention "small and large box" but since the same color (black) is used for both boxes and since both boxes are touching each other, I believe there should be a small horizontal distance between those boxes. Otherwise, 2 distinct colors should have been used. -------------- vertical-align-117 and 118 have limited and restrained relevance if font-size is the same as/equal to the height of line box. -------------- Proposed replacements ===================== http://www.gtalbot.org/BrowserBugsSection/css21testsuite/vertical-align-112-GT.xht http://www.gtalbot.org/BrowserBugsSection/css21testsuite/vertical-align-114-GT.xht which have several important improvements: semantical, calculations in comments, unneeded/extraneous elements and declarations removed. Deconstructed demopage for vertical-align-112 to 120 tests: http://www.gtalbot.org/BrowserBugsSection/css21testsuite/vertical-align-112-deconstructed.xhtml I had to create such demopage so that I could well understand the building logic of these tests. In that demopage, I have painted descent areas so that we can easily see how both glyphs are baseline-aligned and where are the descent areas. regards, Gérard -- Contributions to the CSS 2.1 test suite: http://www.gtalbot.org/BrowserBugsSection/css21testsuite/ CSS 2.1 Test suite RC6, March 23rd 2011: http://test.csswg.org/suites/css2.1/20110323/html4/toc.html CSS 2.1 test suite harness: http://test.csswg.org/harness/ Contributing to to CSS 2.1 test suite: http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
Received on Friday, 2 March 2012 22:30:19 UTC