Re: margin-collapse-023.xht (was RE: 3 Microsoft margin collapsing tests (wrt float, clear and clearance)) from Patrick Garies on 2010-01-26 (public-css-testsuite@w3.org from January 2010)

From: Patrick Garies <pgaries@fastmail.us>
Date: Mon, 25 Jan 2010 18:19:43 -0600
To: css21testsuite@gtalbot.org
CC: Arron Eicholz <Arron.Eicholz@microsoft.com>, "public-css-testsuite@w3.org" <public-css-testsuite@w3.org>
Message-ID: <4B5E351F.8060706@fastmail.us>

On 2010-01-25 3:15 PM, Gérard Talbot wrote:
>>> http://test.csswg.org/source/contributors/microsoft/submitted/Chapter_8/
>>> margin-collapse-023.xht
> One linguistic nitpick.
>
> Please add the preposition "to" in the assert. Even in French, the verb
> adjoin requires the "to" preposition in such sentence. Section 8.3.1
> uses such "to" preposition too in such sentence.
>
>          <meta name="assert" content="If a block-level sibling has
> clearance then the bottom margin of its previous sibling will
> not be adjoining its top margin." />
>
> should become
>
>          <meta name="assert" content="If a block-level sibling has
> clearance then the bottom margin of its previous sibling will
> not be adjoining to its top margin." />

Or you could just change "will not be adjoining to" to "will not adjoin".

Again, "its" should explicitly reference something for clarity.

Commas also help: "If a block-level sibling has clearance, then...". I 
hate the habit that people have of omitting commas; splitting sentences 
into discrete parts (via commas) makes things easier to read.

Received on Tuesday, 26 January 2010 00:20:17 UTC