- From: Gérard Talbot <css21testsuite@gtalbot.org>
- Date: Sat, 28 Nov 2009 10:55:08 -0800
- To: public-css-testsuite@w3.org
Hello all, > Today, I'd like to submit a variety of new test cases:- > > http://test.csswg.org/source/contributors/jameshopkins/submitted/list-style-position/overflow/list-style-position-003.html > http://test.csswg.org/source/contributors/jameshopkins/submitted/list-style-position/overflow/list-style-position-004.html > http://test.csswg.org/source/contributors/jameshopkins/submitted/list-style-position/float/list-style-position-005.html > http://test.csswg.org/source/contributors/jameshopkins/submitted/list-style-position/float/list-style-position-006.html > http://test.csswg.org/source/contributors/jameshopkins/submitted/list-style-position/float/list-style-position-007.html James, in that submitted/list-style-position/float/list-style-position-007.html I suggest to replace "browser window" with "page" since the tests are aimed at several UAs. So, " To pass, there must be a circular symbol to the left of the browser window, and a square/rectangle to the right of the browser window. " can be replaced with " To pass, there must be a circular symbol to the left of the page, and a square/rectangle to the right of the page. " Also, in that test, why not just say "square"? Why say "square/rectangle"? Also in that same test, I think <title>CSS Test: Marker box position - adjacent sibling block box with 'float:right'</title> should be reviewed. And it seems that such test is actually testing 2 distinct, separate expected results: marker box position and float applied to nested child. > http://test.csswg.org/source/contributors/jameshopkins/submitted/text-decoration/visibility/text-decoration-001.html > http://test.csswg.org/source/contributors/jameshopkins/submitted/text-decoration/visibility/text-decoration-002.html > http://test.csswg.org/source/contributors/jameshopkins/submitted/text-decoration/visibility/text-decoration-003.html > http://test.csswg.org/source/contributors/jameshopkins/submitted/text-decoration/visibility/text-decoration-004.html > http://test.csswg.org/source/contributors/jameshopkins/submitted/text-decoration/visibility/text-decoration-005.html > http://test.csswg.org/source/contributors/jameshopkins/submitted/text-decoration/visibility/text-decoration-006.html > http://test.csswg.org/source/contributors/jameshopkins/submitted/text-decoration/visibility/text-decoration-007.html > http://test.csswg.org/source/contributors/jameshopkins/submitted/text-decoration/visibility/text-decoration-008.html > http://test.csswg.org/source/contributors/jameshopkins/submitted/text-decoration/visibility/text-decoration-009.html > http://test.csswg.org/source/contributors/jameshopkins/submitted/text-decoration/visibility/text-decoration-010.html > http://test.csswg.org/source/contributors/jameshopkins/submitted/text-decoration/visibility/text-decoration-011.html > http://test.csswg.org/source/contributors/jameshopkins/submitted/text-decoration/visibility/text-decoration-012.html In all of your visibility/text-decoration tests, you have this sort of structural markup: <div id="test"> visible <span>hidden</span> </div> I suggest to use instead: <div> Filler text <span>FAILED</span> </div> so that the tester would know immediately that the test failed for some reason if visibility hidden was not honored. Also, id="test" is not needed since there is only 1 wrapping div container in all your tests. <div id="test"> does not add any useful meaning, helpful significance to your tests. > http://test.csswg.org/source/contributors/jameshopkins/submitted/text-decoration/text-decoration-013.html > http://test.csswg.org/source/contributors/jameshopkins/submitted/text-decoration/text-decoration-014.html > http://test.csswg.org/source/contributors/jameshopkins/submitted/text-decoration/text-decoration-015.html > http://test.csswg.org/source/contributors/jameshopkins/submitted/text-decoration/text-decoration-016.html > http://test.csswg.org/source/contributors/jameshopkins/submitted/text-decoration/text-decoration-017.html There are also other more "nitpicking" issues which I have emailed you about. best regards, Gérard -- Contributions to the CSS 2.1 test suite: http://www.gtalbot.org/BrowserBugsSection/css21testsuite/ CSS 2.1 test suite (pre-alpha): http://www.w3.org/Style/CSS/Test/CSS2.1/current/html4/ CSS 2.1 test suite contributors: http://test.csswg.org/source/contributors/
Received on Saturday, 28 November 2009 18:55:50 UTC