Re: [CSS2.1] t1508-c527-font-08-b.xht

fantasai wrote:
> 
> Grant, Melinda wrote:
>>  
>>  It looks to me like either the style instruction for the line height in
>> this test should be modified, or the description should.
>>
>> I would expect "{font: oblique normal 700 18px/200% sans-serif;}" to
>> yield an 18 px gap rather than the 9px gap indicated in the description,
>> no?
> 
> That's correct. I'll update the description to say that there should
> be 36px between baselines.

I've checked in the attached changes. Please verify that they're ok.

~fantasai
Index: CSS2.1-test-suite/raw-tests/css1tests/css1test527b.xml
===================================================================
RCS file: /sources/public/CSS/CSS2.1-test-suite/raw-tests/css1tests/css1test527b.xml,v
retrieving revision 1.2
diff -u -r1.2 css1test527b.xml
--- CSS2.1-test-suite/raw-tests/css1tests/css1test527b.xml	25 Apr 2007 16:29:00 -0000	1.2
+++ CSS2.1-test-suite/raw-tests/css1tests/css1test527b.xml	12 Jun 2007 20:52:05 -0000
@@ -12,7 +12,8 @@
  </head>
  <body>
   <p class="two">
-   This text should be 18px serif. There should be a 9px gap between each line.
+   This text should be 18px serif. There should be 27px between baselines
+   (9px gap between lines).
    <span class="dummy"> dummy text dummy text dummy text dummy text dummy text dummy
    text dummy text dummy text dummy text dummy text dummy text dummy
    text dummy text dummy text dummy text dummy text dummy text dummy
Index: CSS2.1-test-suite/raw-tests/css1tests/css1test527c.xml
===================================================================
RCS file: /sources/public/CSS/CSS2.1-test-suite/raw-tests/css1tests/css1test527c.xml,v
retrieving revision 1.2
diff -u -r1.2 css1test527c.xml
--- CSS2.1-test-suite/raw-tests/css1tests/css1test527c.xml	25 Apr 2007 16:29:00 -0000	1.2
+++ CSS2.1-test-suite/raw-tests/css1tests/css1test527c.xml	12 Jun 2007 20:52:05 -0000
@@ -12,7 +12,8 @@
  </head>
  <body>
   <p class="three">
-   This text should be 18px sans-serif. There should be a 9px gap between each line.
+   This text should be 18px sans-serif. There should be 27px between baselines
+   (9px gap between lines).
    <span class="dummy"> dummy text dummy text dummy text dummy text dummy text dummy
    text dummy text dummy text dummy text dummy text dummy text dummy
    text dummy text dummy text dummy text dummy text dummy text dummy
Index: CSS2.1-test-suite/raw-tests/css1tests/css1test527e.xml
===================================================================
RCS file: /sources/public/CSS/CSS2.1-test-suite/raw-tests/css1tests/css1test527e.xml,v
retrieving revision 1.2
diff -u -r1.2 css1test527e.xml
--- CSS2.1-test-suite/raw-tests/css1tests/css1test527e.xml	25 Apr 2007 16:29:00 -0000	1.2
+++ CSS2.1-test-suite/raw-tests/css1tests/css1test527e.xml	12 Jun 2007 20:52:05 -0000
@@ -12,7 +12,8 @@
  </head>
  <body>
   <p class="five">
-   This text should be 18px sans-serif, in small-caps, italicized, and very bold. There should be a 9px gap between each line.
+   This text should be 18px sans-serif, in small-caps, italicized, and very bold.
+   There should be 27px between baselines (9px gap between lines).
    <span class="dummy"> dummy text dummy text dummy text dummy text dummy text dummy
    text dummy text dummy text dummy text dummy text dummy text dummy
    text dummy text dummy text dummy text dummy text dummy text dummy
Index: CSS2.1-test-suite/raw-tests/css1tests/css1test527f.xml
===================================================================
RCS file: /sources/public/CSS/CSS2.1-test-suite/raw-tests/css1tests/css1test527f.xml,v
retrieving revision 1.2
diff -u -r1.2 css1test527f.xml
--- CSS2.1-test-suite/raw-tests/css1tests/css1test527f.xml	25 Apr 2007 16:29:00 -0000	1.2
+++ CSS2.1-test-suite/raw-tests/css1tests/css1test527f.xml	12 Jun 2007 20:52:05 -0000
@@ -14,8 +14,9 @@
  </head>
  <body>
   <p class="six">
-   This text should be 18px sans-serif, in small-caps, italicized, and very light. There should be a 36px gap between each line.
-   <span class="dummy"> dummy text dummy text dummy text dummy text dummy text dummy
+   This text should be 18px sans-serif, in small-caps, italicized, and very light.
+   There should be 54px between baselines (36px gap between lines).
+  <span class="dummy"> dummy text dummy text dummy text dummy text dummy text dummy
    text dummy text dummy text dummy text dummy text dummy text dummy
    text dummy text dummy text dummy text dummy text dummy text dummy
    text dummy text dummy text dummy text dummy text dummy text dummy
Index: CSS2.1-test-suite/raw-tests/css1tests/css1test527h.xml
===================================================================
RCS file: /sources/public/CSS/CSS2.1-test-suite/raw-tests/css1tests/css1test527h.xml,v
retrieving revision 1.2
diff -u -r1.2 css1test527h.xml
--- CSS2.1-test-suite/raw-tests/css1tests/css1test527h.xml	25 Apr 2007 16:29:00 -0000	1.2
+++ CSS2.1-test-suite/raw-tests/css1tests/css1test527h.xml	12 Jun 2007 20:52:05 -0000
@@ -12,7 +12,8 @@
  </head>
  <body>
   <p class="eight">
-   This text should be 18px sans-serif, in small-caps and italicized. The lines should be one inch apart.
+   This text should be 18px sans-serif, in small-caps and italicized.
+   The baselines should be one inch apart.
    <span class="dummy"> dummy text dummy text dummy text dummy text dummy text dummy
    text dummy text dummy text dummy text dummy text dummy text dummy
    text dummy text dummy text dummy text dummy text dummy text dummy
Index: CSS2.1-test-suite/raw-tests/css1tests/css1test527i.xml
===================================================================
RCS file: /sources/public/CSS/CSS2.1-test-suite/raw-tests/css1tests/css1test527i.xml,v
retrieving revision 1.2
diff -u -r1.2 css1test527i.xml
--- CSS2.1-test-suite/raw-tests/css1tests/css1test527i.xml	25 Apr 2007 16:29:00 -0000	1.2
+++ CSS2.1-test-suite/raw-tests/css1tests/css1test527i.xml	12 Jun 2007 20:52:05 -0000
@@ -12,7 +12,8 @@
  </head>
  <body>
   <p class="nine">
-   This text should be 18px sans-serif, in small-caps, oblique, and bold. There should be a 9px gap between each line.
+   This text should be 18px sans-serif, in small-caps, oblique, and bold.
+   There should be 36px between baselines (18px gap between lines).
    <span class="dummy"> dummy text dummy text dummy text dummy text dummy text dummy
    text dummy text dummy text dummy text dummy text dummy text dummy
    text dummy text dummy text dummy text dummy text dummy text dummy
Index: CSS2.1-test-suite/raw-tests/css1tests/css1test527j.xml
===================================================================
RCS file: /sources/public/CSS/CSS2.1-test-suite/raw-tests/css1tests/css1test527j.xml,v
retrieving revision 1.2
diff -u -r1.2 css1test527j.xml
--- CSS2.1-test-suite/raw-tests/css1tests/css1test527j.xml	25 Apr 2007 16:29:00 -0000	1.2
+++ CSS2.1-test-suite/raw-tests/css1tests/css1test527j.xml	12 Jun 2007 20:52:05 -0000
@@ -5,14 +5,15 @@
   <link rel="author" title="CSS1 Test Suite Contributors" href="http://www.w3.org/Style/CSS/Test/CSS1/current/tsack.html"/>
   <link rel="author" title="Ian Hickson" href="mailto:ian@hixie.ch"/>
   <style type="text/css"><![CDATA[
-   body {font-size: 12px; color: navy;}
-   .ten {font: normal 400 80%/2.5 sans-serif;}
+   body {font-size: 16px; color: navy;}
+   .ten {font: normal 400 75%/2.5 sans-serif;}
    span.dummy {color: silver;}
   ]]></style>
  </head>
  <body>
   <p class="ten">
-   This test should be about 10px, sans-serif, and light. There should be about 15px between each line.
+   This test should be 12px, sans-serif, and light.
+   There should be 30px between baselines (18px gap between lines).
    <span class="dummy"> dummy text dummy text dummy text dummy text dummy text dummy
    text dummy text dummy text dummy text dummy text dummy text dummy
    text dummy text dummy text dummy text dummy text dummy text dummy
Index: CSS2.1-test-suite/raw-tests/css1tests/css1test527k.xml
===================================================================
RCS file: /sources/public/CSS/CSS2.1-test-suite/raw-tests/css1tests/css1test527k.xml,v
retrieving revision 1.2
diff -u -r1.2 css1test527k.xml
--- CSS2.1-test-suite/raw-tests/css1tests/css1test527k.xml	25 Apr 2007 16:29:00 -0000	1.2
+++ CSS2.1-test-suite/raw-tests/css1tests/css1test527k.xml	12 Jun 2007 20:52:05 -0000
@@ -15,8 +15,9 @@
   <p class="eleven">
    <span class="color">
     This text should be 18px sans-serif, in small-caps, italicized,
-    and very light. There should be a 36px gap betwen each line. The
-    text should have a blue background, the gap should not.
+    and very light. There should be 54px between baselines, with a
+    36px gap between lines. The text should have a blue background,
+    the gap should not.
     <span class="dummy"> dummy text dummy text dummy text dummy text dummy text dummy
     text dummy text dummy text dummy text dummy text dummy text dummy
     text dummy text dummy text dummy text dummy text dummy text dummy

Received on Tuesday, 12 June 2007 20:57:27 UTC