[csswg-drafts] Pull Request: [css-rythm-1] [editorial] remove redundant `px` dimension from `line-height-step` initial value

frivoal has just labeled a pull request from keithamus for https://github.com/w3c/csswg-drafts as "css-rhythm-1":

== [css-rythm-1] [editorial] remove redundant `px` dimension from `line-height-step` initial value ==
The `line-height-step` property in css-rythm-1 defines its initial value as `0px`. AIUI - it being a zero value means the `px` is redundant.

It seems to be more common to use `0` rather than `0px`. In fact here are all the places that have an initial of `0`:
 - css-box (`margin*`, `padding*`)
 - css-scroll-snap (`scroll-margin*`)
 - css-inline (`baseline-shift`)
 - css-shapes (`shape-margin`, `shape-padding`)
 - css-text (`text-indent`, `line-padding`, `hyphenate-limit-zone`)
 - css-text-decor (`text-decoration-trim`)
 - css-ui (`outline-offset`)
 - css-borders (`border-*-radius` & `border-radius`)
 - css-logical (okay maybe an unfair comparison as it's mostly logical equivalents of box/borders)
 
And here are the places that have an initial of `0px`:
 - css-rythm (`line-height-step` - that's this one)
 - css-tables (`border-spacing` - this initial value is `0px 0px`)
 - css-animation (`animation-delay` - `0s`)
 - css-animation (`transition-delay`, `transition-duration` - both `0s`)
 - css-overflow (`overflow-clip-margin*` - all `0px`)
 - css-backgrounds (`background-position*` - all `0%`)

If this PR gets merged I'll follow up with one correcting `css-overflow` and perhaps the others 😉

See https://github.com/w3c/csswg-drafts/pull/11148


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Monday, 4 November 2024 00:24:06 UTC