Re: [csswg-drafts] [css-animations-2] Specify the animation-trigger property (#10128)

Thanks @birtles!

> currently on parental leave

Congrats ^_^!

> 1. I think this should be part of Web Animations level 2.

Ok, I also wondered about that, but @flackr wrote Web Animations 1, and some things I needed to update were actually there, so not sure whether this was intentional or not.

> 2. I think we need to define the API parts for triggers?

You mean the DOM interfaces, as in [here](https://drafts.csswg.org/css-animations-1/#interface-dom)?

> 3. We probably need to review all the descriptions about timelines and animations to make sure it accounts for triggers. (e.g. the sentence "Updating the [current time](https://drafts.csswg.org/web-animations-1/#animation-current-time) of any [animations](https://drafts.csswg.org/web-animations-1/#concept-animation) [associated with](https://drafts.csswg.org/web-animations-1/#associated-with-a-timeline) the timeline." should probably refer to triggers too?)

I've added [this text](https://github.com/w3c/csswg-drafts/pull/10128/files#diff-c240da42474be67dd65a2e91af4774da3cd91e832e1a6401b9fbefd6efe18851R775) to that section:

> * Updating the [=animation trigger state=] of any [=animation trigger=]
              [=associated with a timeline|associated with=] the timeline.

Shouldn't this cover it? I think basically comes down to checking triggers state on timeline's current time update.

-- 
GitHub Notification of comment by ydaniv
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/pull/10128#issuecomment-2093181240 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Friday, 3 May 2024 14:53:06 UTC