Re: [csswg-drafts] [css-view-transitions-1] Which skipping reason does "View transition page-visibility change steps" use? (#10101) from Tim Nguyen via GitHub on 2024-03-20 (public-css-archive@w3.org from March 2024)

From: Tim Nguyen via GitHub <sysbot+gh@w3.org>
Date: Wed, 20 Mar 2024 08:44:50 +0000
To: public-css-archive@w3.org
Message-ID: <issue_comment.created-2009045578-1710924287-sysbot+gh@w3.org>

I also noticed another bug in the spec:

In https://drafts.csswg.org/css-view-transitions-1/#ViewTransition-prepare

> If document’s [visibility state](https://html.spec.whatwg.org/multipage/interaction.html#visibility-state) is "hidden", then [skip](https://drafts.csswg.org/css-view-transitions-1/#skip-the-view-transition) transition with an "[InvalidStateError](https://webidl.spec.whatwg.org/#invalidstateerror)" [DOMException](https://webidl.spec.whatwg.org/#idl-DOMException), and return.

We should be returning the `transition` here, instead of returning nothing.

-- 
GitHub Notification of comment by nt1m
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/10101#issuecomment-2009045578 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Wednesday, 20 March 2024 08:44:51 UTC