- From: Brian Birtles via GitHub <sysbot+gh@w3.org>
- Date: Thu, 22 Feb 2024 03:13:21 +0000
- To: public-css-archive@w3.org
I've reviewed this PR and I think it looks good. Thanks @DavMila for your work on this. My only outstanding question is [from here](https://github.com/w3c/csswg-drafts/pull/9937#discussion_r1491825782): > We _could_ mimic the behaviour of `progress` on `ComputedEffectTiming` and use the fill mode and phase of the root animation effect to make `progress` be `unresolved` when the root effect is not in effect but that might be a bit of a layering violation? > > ... > > I guess it comes back to reviewing these issues and seeing what would work best in each of those cases (quoting #8799): > > > In https://github.com/w3c/csswg-drafts/issues/8669, https://github.com/w3c/csswg-drafts/issues/8765 and https://github.com/w3c/csswg-drafts/issues/8201 there seems to be a common desire to have more convenient APIs for getting some representation of progress. Does anyone know any specific intended uses of this API that would help determine if the progress should be unresolved when the animation is in the before/after phase and not filling? -- GitHub Notification of comment by birtles Please view or discuss this issue at https://github.com/w3c/csswg-drafts/pull/9937#issuecomment-1958579980 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Thursday, 22 February 2024 03:13:23 UTC