- From: Daniel Holbert via GitHub <sysbot+gh@w3.org>
- Date: Wed, 01 Jun 2022 22:06:03 +0000
- To: public-css-archive@w3.org
> @dholbert - Can you confirm my interpretation of FFs code in [#6794 (comment)](https://github.com/w3c/csswg-drafts/issues/6794#issuecomment-1068406900) is correct? I think it's not correct (i.e. I don't think Firefox implements the behavior you're suggesting, at least not in that particular snippet). Your searchfox link there was unstable since it's pointing the evergreen current-tip-of-tree, so it's now pointing at different snippet of code than it was when you posted it. (FYI, you can press "y" on any searchfox page to immediately jump to the commit-specific perma-link version of that page, BTW.) Looking at history, it looks like you were intending to point to this code: https://searchfox.org/mozilla-central/rev/1739f1301d658c9bff544a0a095ab11fca2e549d/layout/base/nsLayoutUtils.cpp#4978-4982 That code was added in bug 364066, here: https://hg.mozilla.org/mozilla-central/rev/427bda154a0a003554a62c825fdd825c2b933943#l1.91 ...and it's just been carried forward from that point to now handle writing-modes and `auto` as the new default min-size value. That code was & still-is essentially transferring nonzero constraints in the opposite axis, when computing the *intrinsic-size contribution* of an element with an aspect ratio. Our check for `styleMinBSize.IsAuto()` there is not analogous to the `box.Style().MinSize() == "auto"` in your pseudo-code. (I think that might have been what you suspected / what the core of your question is?) Rather, our auto-ness check there is just treating `min-bsize:auto` as being equivalent to `0` [1] as an "un-interesting" transferred size from the perspective of this code-snippet. [1] the check for `min-bsize:auto` there was added in https://hg.mozilla.org/mozilla-central/rev/fc15aa6922065e4396084fb2d87e4486549a8bf6#l1.30 with comment indicating that we were adding it as an alias for `0`, essentially, from the perspective of the surrounding logic. -- GitHub Notification of comment by dholbert Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/6794#issuecomment-1144188679 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Wednesday, 1 June 2022 22:06:05 UTC