- From: Noam Rosenthal via GitHub <sysbot+gh@w3.org>
- Date: Wed, 06 Oct 2021 09:49:47 +0000
- To: public-css-archive@w3.org
> In addition to the individual comments nits, most of which can be fixed by accepting the provided suggestions, there's some style nits where your additions don't match the surrounding spec and would need to be reformatted at some point by us. > > CSSWG style is to give the algo steps their actual numbers when using Markdown numbered lists, and most importantly, we use semantic linebreaks, breaking at sentence/phrase/clause boundaries (usually after commas or before conjunctions) as feels appropriate for meaningful units of text that aren't overly long. OK I fixed that as well. Let me know if anything else is missing. > Would you mind also doing the CSSOM "load a stylesheet" algo? (In this PR or separate, doesn't matter.) I will try to find the time to look at this separately, and it probably wouldn't use the "fetch a style resource" algorithm as stylesheets loaded like that are not exactly style resources. Seems like that algorithm is only used internally in CSSOM, for things like XML stylesheets and link headers. I wouldn't use it for HTML, as it would require too much information about `link` element specifics. -- GitHub Notification of comment by noamr Please view or discuss this issue at https://github.com/w3c/csswg-drafts/pull/6715#issuecomment-935867990 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Wednesday, 6 October 2021 09:49:49 UTC