W3C home > Mailing lists > Public > public-css-archive@w3.org > July 2021

Re: [csswg-drafts] [css-flexbox] should a definite flex-basis always make the main size be definite? (#4311)

From: CSS Meeting Bot via GitHub <sysbot+gh@w3.org>
Date: Wed, 21 Jul 2021 16:44:12 +0000
To: public-css-archive@w3.org
Message-ID: <issue_comment.created-884334170-1626885850-sysbot+gh@w3.org>
The CSS Working Group just discussed `Does definite flex-basis always cause main size definite?`.

<details><summary>The full IRC log of that discussion</summary>
&lt;fantasai> Topic: Does definite flex-basis always cause main size definite?<br>
&lt;fantasai> github: https://github.com/w3c/csswg-drafts/issues/4311<br>
&lt;fantasai> TabAtkins: There's an example in the issue<br>
&lt;fantasai> TabAtkins: Column flexbox with a flexible child<br>
&lt;fantasai> TabAtkins: child has a definite height, but it is flexible so can become larger or smaller<br>
&lt;fantasai> TabAtkins: Flex item has a child with a percentage height<br>
&lt;TabAtkins> my phone hung up, one sec<br>
&lt;TabAtkins> OKAY I CAN'T MAKE A CALL ANY MORE<br>
&lt;TabAtkins> welp<br>
&lt;fantasai> fantasai: Spec says this case is indefinite, and percentage won't resolve<br>
&lt;fantasai> fantasai: But implementations do resolve<br>
&lt;fantasai> fantasai: so should we change the spec to match implementations?<br>
&lt;fantasai> iank_: I think all of the implementations are following the spec here<br>
&lt;fantasai> iank_: in that they are not resolving ...<br>
&lt;fantasai> cbiesinger: Not true<br>
&lt;fantasai> cbiesinger: Testcase is red, which means it is resolving<br>
&lt;fantasai> cbiesinger: Interesting thing here is that the percentage would resolve outside a flexbox<br>
&lt;fantasai> cbiesinger: it doesn't resolve if you put it inside the flexbox (per spec)<br>
&lt;fantasai> cbiesinger: I doubt authors expect that<br>
&lt;fantasai> fantasai: Originaly definiteness was identifying cases where percentages are very simple to calculate<br>
&lt;fantasai> fantasai: and we restricted percentage resolution to these cases<br>
&lt;fantasai> fantasai: but authors would be happier to resolve more often<br>
&lt;fantasai> fantasai: so if implementers are already doing it, might as well match the spec<br>
&lt;fantasai> iank_: this seems fine to me<br>
&lt;fantasai> fantasai: does mean that concept of definiteness is more complicated<br>
&lt;fantasai> cbiesinger: Want to mention, in Chrome we only take into account the width/height property, not the flex-basis. But that's probably a Chrome bug<br>
&lt;fantasai> Rossen_: Do we know if this is safe to change?<br>
&lt;jensimmons> q+<br>
&lt;fantasai> fantasai: Planning to match spec to implementations, so shouldn't have any concerns<br>
&lt;dholbert> q+<br>
&lt;Rossen_> ack jensimmons<br>
&lt;fantasai> jensimmons: Seems folks doing a good job of raising flex bugs and addressing them<br>
&lt;fantasai> jensimmons: Would love to ask if filing bugs against WebKit as well, seems our implementation is same as Chrome<br>
&lt;fantasai> iank_: No bug required here, spec is aligning ot implementations<br>
&lt;fantasai> jensimmons: on this issue, but not last one<br>
&lt;fantasai> cbiesinger: should be a wpt test also<br>
&lt;fantasai> Rossen_: WPT tests should raise to webkit<br>
&lt;jensimmons> no<br>
&lt;Rossen_> ack jensimmons<br>
&lt;Rossen_> ack dholbert<br>
&lt;fantasai> dholbert: Wanted to clarify what the proposed change is here. Are we making the spec match implementations in this case?<br>
&lt;cbiesinger> I think change is: definite flex-basis makes the size definite, even if the item is flexible<br>
&lt;fantasai> dholbert: I think that doesn't match what we do<br>
&lt;fantasai> dholbert: It might be that this case is triggering a more subtle situation<br>
&lt;fantasai> fantasai: That's interesting, we should investigate<br>
&lt;fantasai> dholbert: I think intent of our behavior is to match the spec<br>
&lt;fantasai> dholbert: We do check if flex item is flexible when testing for flexible flex-basis, to see if we want to make item definite<br>
&lt;fantasai> cbiesinger: I feel like you and I had a discussion about this years ago and you were going to match our behavior<br>
&lt;fantasai> dholbert: We fixed a number of bugs in last 6 months also<br>
&lt;fantasai> dholbert: so maybe previously did something more esoteric<br>
&lt;fantasai> fantasai, rossen: maybe need to go back to GH to figure out<br>
&lt;Rossen_> q?<br>
</details>


-- 
GitHub Notification of comment by css-meeting-bot
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/4311#issuecomment-884334170 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Wednesday, 21 July 2021 16:44:13 UTC

This archive was generated by hypermail 2.4.0 : Thursday, 24 March 2022 20:27:25 UTC