W3C home > Mailing lists > Public > public-css-archive@w3.org > January 2021

Re: [csswg-drafts] [web-animations] Could commitStyles always write the end state of the animation? (#5394)

From: Brian Birtles via GitHub <sysbot+gh@w3.org>
Date: Thu, 14 Jan 2021 00:33:19 +0000
To: public-css-archive@w3.org
Message-ID: <issue_comment.created-759845779-1610584398-sysbot+gh@w3.org>
> I strongly agree with all of your suggested answers. I think this is going to be the least surprising and most compatible way to implement it.

Great, thanks Rob!

> One thought about point 1 (doesn't affect this proposal), given that commitStyles applies styles at the bottom of the animation stack (i.e. because inline style applies before animation styles), it seems as if commitStyles could only apply the current animation rather than all animations beneath it with the expectation that you would have already had an opportunity to commit the animations below it. This may be less surprising than committing the effect of multiple animations with one call.

Yeah, I'm a little confused about this part. I _think_ the idea was that by compositing the lower animations, the result would be correct even if some of the animations lower in the cascade had not yet been removed but, as you point out, any such animations would clobber the inline style.

The [WPT for commitStyles](https://github.com/web-platform-tests/wpt/blob/master/web-animations/interfaces/Animation/commitStyles.html) includes a few cases where it makes a difference, but I don't know if any of them represent real use cases.

-- 
GitHub Notification of comment by birtles
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/5394#issuecomment-759845779 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Thursday, 14 January 2021 00:33:21 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 19 October 2021 01:31:38 UTC