W3C home > Mailing lists > Public > public-css-archive@w3.org > January 2021

Re: [csswg-drafts] [css-grid] Note implies losing an aspect-ratio when it shouldn't? (#5713)

From: CSS Meeting Bot via GitHub <sysbot+gh@w3.org>
Date: Thu, 07 Jan 2021 00:17:28 +0000
To: public-css-archive@w3.org
Message-ID: <issue_comment.created-755791551-1609978647-sysbot+gh@w3.org>
The CSS Working Group just discussed `[css-grid] Note implies losing an aspect-ratio when it shouldn't?`, and agreed to the following:

* `RESOLVED: stretch alignment doesn't disable the aspect ratio. It can distort it if the other axis is constrained`

<details><summary>The full IRC log of that discussion</summary>
&lt;dael> Topic: [css-grid] Note implies losing an aspect-ratio when it shouldn't?<br>
&lt;dael> github: https://github.com/w3c/csswg-drafts/issues/5713<br>
&lt;dael> fantasai: Have agreement that stretch on its own in single axis shoudl cause you to lose aspect ratio.<br>
&lt;dael> fantasai: I think we're clear on that and it's editorial. We did have impl doing something different<br>
&lt;fantasai> https://github.com/w3c/csswg-drafts/commit/f5823bc7d64106a160b5473a972bbb744f27262b<br>
&lt;fantasai> clarification ^<br>
&lt;fantasai> https://github.com/w3c/csswg-drafts/commit/93ea82e30baf4c9b887a5d60e89f90a5411e94f7<br>
&lt;fantasai> additional fix in css-align ^<br>
&lt;dael> iank_: I filed this b/c we were looking how stretching works in a single axis internally. Noticed all impl of grid throw away aspect ratio in this condition. I think a lot of confusion was from note which is being fixed<br>
&lt;dael> iank_: 10-15 tests in the suite which are testing the broken behavior. I'm prepared to fix the tests but it would mean all impl will fail the tests<br>
&lt;dael> iank_: If we have agreement this is correct, then this is an fyi to fix impl<br>
&lt;dael> dholbert: Does this make grid more like flexbox?<br>
&lt;dael> dholbert: More consistent or shifting?<br>
&lt;dael> iank_: Yes, makes them more consistent. If you stretch image in one axis the a-r is typically preserved<br>
&lt;dael> fantasai: I think the fix to the note is correct. Will this change behavior for an image with no alignment but it is in a grid. normal in both axis. If that behavior would change there's web compat issue<br>
&lt;dael> iank_: normal in both axis doesn't imply stretching so it's fine. This is only when stretching in one axis or the other<br>
&lt;dael> Rossen_: And stretching only?<br>
&lt;astearns> q?<br>
&lt;dael> iank_: Correct. The weirdness here is that if you stretch in the inline axis for a grid item the image was distorted. You have to opt into this so I'm fairly sure it's web compat. But there are a lot of tests testing the broken behavior<br>
&lt;dael> astearns: Would it make sense when you update tests for you to open bugs on all engines?<br>
&lt;dael> iank_: Depending on set up tests themselves failing might cover. Does cover FF. But I'm happy to file bugs as well<br>
&lt;dael> astearns: Anyone with concerns?<br>
&lt;dael> fantasai: Prop: stretch alignment doesn't disable the aspect ratio. It can distort it if the other axis is constrained<br>
&lt;dael> astearns: Objections?<br>
&lt;dael> RESOLVED: stretch alignment doesn't disable the aspect ratio. It can distort it if the other axis is constrained<br>
</details>


-- 
GitHub Notification of comment by css-meeting-bot
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/5713#issuecomment-755791551 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Thursday, 7 January 2021 00:17:31 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 19 October 2021 01:31:38 UTC