Re: [csswg-drafts] [css-cascade] Custom Cascade Layers (formerly "custom origins") (#4470)

I think this is a well-written proposal. Thank you for such a clear exposition. I think it definitely helps us explore the space of how far we could go with layer semantics. I also left a few questions and thoughts in the comment thread on the [gist](https://gist.github.com/mirisuzanne/4224caca74a0d4be33a2b565df34b9e7).

My summary feedback:

I think the block syntax looks good.

I have some concerns about the external-sheet loading syntax, in particular: whether developers will find it [too confusing or difficult to debug](https://gist.github.com/mirisuzanne/4224caca74a0d4be33a2b565df34b9e7#gistcomment-3416994), implementation complexity, and the potential for race conditions ([example](https://gist.github.com/mirisuzanne/4224caca74a0d4be33a2b565df34b9e7#gistcomment-3416999)).

I have a [concern](https://gist.github.com/mirisuzanne/4224caca74a0d4be33a2b565df34b9e7#gistcomment-3416944) about how well this proposal satisfies the use case of importing common third-party styling libraries.

This proposal does seem to be backward-compatible with an incremental implementation and shipping approach, along the lines of what I suggested [here](https://github.com/w3c/csswg-drafts/issues/4969#issuecomment-663610493), which is great. (We'd pre-define certain built-in layers, not allow defining new ones, and not support url import syntax.)

It's also good that it appears this approach is also polyfillable.


-- 
GitHub Notification of comment by chrishtr
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/4470#issuecomment-673840146 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Friday, 14 August 2020 01:56:08 UTC