W3C home > Mailing lists > Public > public-css-archive@w3.org > November 2019

Re: [csswg-drafts] [css-grid-2] Subsetting grid-template-areas in subgrids (#4411)

From: CSS Meeting Bot via GitHub <sysbot+gh@w3.org>
Date: Wed, 13 Nov 2019 17:20:41 +0000
To: public-css-archive@w3.org
Message-ID: <issue_comment.created-553503122-1573665640-sysbot+gh@w3.org>
The CSS Working Group just discussed `Subsetting grid-template-areas in subgrids`, and agreed to the following:

* `RESOLVED: Pick option 2 effectively subset the grid area into the subgrid`

<details><summary>The full IRC log of that discussion</summary>
&lt;dael> Topic: Subsetting grid-template-areas in subgrids<br>
&lt;dael> github: https://github.com/w3c/csswg-drafts/issues/4411<br>
&lt;fantasai> https://github.com/w3c/csswg-drafts/issues/4411#issuecomment-548945615<br>
&lt;dael> fantasai: Summary comment^<br>
&lt;dael> fantasai: Two proposals, make grid-template-areas a thing and exclude names from inheriting. Currently grid-templates make start and end and those would not inherit into subgrid<br>
&lt;dael> fantasai: Other option is we take those names and instead of saying don't inherit in, they do inherit in and if there's partial overlap we clip start or end so they exist in the grid and you can position to the overlap<br>
&lt;dael> fantasai: Slight inconsitencies for both. If we exclude then a manually created grid area such as named lines as foo-start I implicitly create foo which I can position into. Kinda works on a subgrid; if both lines overlap. True in both cases<br>
&lt;dael> fantasai: Question is do we want...we didn't want to create inconsisent behavior for tempaltes. Want to say either set to part it overlaps or exclude all lines. Those are the two options.<br>
&lt;dael> fantasai: Would like to hear from other preference<br>
&lt;dael> Rossen_: Prefer second option.<br>
&lt;fantasai> A) Exclude parent template and its implicit line names from subgrid<br>
&lt;fantasai> B) Subset parent template to the part where it overlaps the subgrid, allowing it to be usable<br>
&lt;dael> Rossen_: Having the grid-template-area lines not available from subgrid is quite weird given that rows and columns are available<br>
&lt;dael> Rossen_: I would lean toward the second solution if we have to pick from these two<br>
&lt;dael> dbaron: Looks like Mats preference was first, but seems reasonably okay with either. Seems he had impl of 2nd and changed to 1st.<br>
&lt;dael> fantasai: He originally wanted B, then did A when we weren't sure<br>
&lt;dael> Rossen_: dbaron do you know why he switched?<br>
&lt;dael> rego: It was not impl in all cases. I had example in issue that was different in 2 cases where should be same. He didn't have whole impl. I think he did the simpliest thing<br>
&lt;fantasai> Mats's comments https://github.com/w3c/csswg-drafts/issues/4411#issuecomment-542292465<br>
&lt;dael> Rossen_: If we go with option B (the second option)<br>
&lt;dael> Rossen_: Would that be okay dbaron if you're representing Mats?<br>
&lt;dael> dbaron: I'm only reading his comments in issue<br>
&lt;dael> jensimmons: Still trying to wrap my head around. Seems like AmeliaBR and rachelandrew were advocating for A<br>
&lt;dael> Rossen_: A in TabAtkins summary is option 2<br>
&lt;AmeliaBR> s/AmeliaBR/Miriam Suzanne/<br>
&lt;rachelandrew> option 2 for me (don't think my mic is working)<br>
&lt;dael> fantasai: rego I think case with a difference is case of explicit line names creating implicit area.<br>
&lt;dael> fantasai: TabAtkins and I discussed and concluded there wasn't a good way to make that work. Would require changes to how line names were handled. Couldn't figure out how to not cause changes to normal grid<br>
&lt;dael> fantasai: Concluded line names from tempate are special and special for subgrids but explicit line names don't. Which means you can handle hte partial overlap nicely for template areas, but not for area with explicit names<br>
&lt;dael> rego: So original impl from Mats is final?<br>
&lt;dael> fantasai: Yeah. Either way the line names created by template area need to be special so we either notice they're excluded or clamped for partial overlaps. Seems second is more useful<br>
&lt;dael> rego: Still don't like difference in the example. I understand it's useful so maybe it's good enough. I think the difference can create confusion.<br>
&lt;dael> fantasai: Ideally we would solve both, but didn't find a good way.<br>
&lt;fantasai> rego, see https://github.com/w3c/csswg-drafts/issues/4411#issuecomment-542288855 for problems with the other options<br>
&lt;dael> Rossen_: Not hearing strong opinions, but more people toward option 2<br>
&lt;dael> Rossen_: Objections to resolving on "Subset parent template to the part where it overlaps the subgrid, allowing it to be usable" unless there's additional comments<br>
&lt;fantasai> Example of option 2 - https://github.com/w3c/csswg-drafts/issues/4411#issuecomment-543174237<br>
&lt;dael> Rossen_: Objections to Option 2: Subset parent template to the part where it overlaps the subgrid, allowing it to be usable ?<br>
&lt;dael> RESOLVED: Pick option 2 effectively subset the grid area into the subgrid<br>

GitHub Notification of comment by css-meeting-bot
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/4411#issuecomment-553503122 using your GitHub account
Received on Wednesday, 13 November 2019 17:20:43 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 5 July 2022 06:41:56 UTC