- From: Daniel Holbert via GitHub <sysbot+gh@w3.org>
- Date: Wed, 20 Sep 2017 00:48:37 +0000
- To: public-css-archive@w3.org
One more issue I'm noticing: suppose we consider Tab's example (https://github.com/w3c/csswg-drafts/issues/1735#issuecomment-328631076 ) and we make one tweak -- we add `margin-left: 50px` to the first flex item. Ideally, this should make the algorithm produce a flex container that is 50px larger (so, 550px). But it doesn't -- it remains at 500px. This is because right now, the margin only comes into play in step 2, and it exactly cancels out so that it doesn't have any effect. ("For each flex item, find its max-content flex fraction: Subtract its outer flex base size from its max-content contribution size" -- my margin tweak makes each of these operands 50px larger, so the margin has no net effect.)
Possible solution: in step 4...
> Add each item’s flex base size to the product of [...]
...maybe "flex base size" should really be "**outer** flex base size"?
--
GitHub Notification of comment by dholbert
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/1735#issuecomment-330713449 using your GitHub account
Received on Wednesday, 20 September 2017 00:49:02 UTC